Handle new unschedulable status #4598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4598 +/- ##
=======================================
Coverage 47.65% 47.65%
=======================================
Files 370 370
Lines 29776 29776
=======================================
Hits 14190 14190
Misses 14476 14476
Partials 1110 1110 |
ifbyol
approved these changes
Dec 3, 2024
jLopezbarb
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the new
Unschedulablestatus as a transition status. This makes deploys and dependencies wait for the deploy timeout before marking is as failed. Note that in the backend we have a 3min cutoff for unschedulable resources so any timeout larger than that was not being considered.This change is dependant on the backend return this new status.