DEV-828: Don't allow execution of empty tests names #4614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4614 +/- ##
==========================================
- Coverage 47.75% 47.74% -0.01%
==========================================
Files 369 369
Lines 29706 29711 +5
==========================================
Hits 14186 14186
- Misses 14421 14426 +5
Partials 1099 1099 |
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
andreafalzetti
approved these changes
Dec 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
* DEV-828: Removed check on integration tests to simulate error case Signed-off-by: Nacho Fuertes <nacho@okteto.com> * DEV-828: Don't allow empty strings as tests containers to run Signed-off-by: Nacho Fuertes <nacho@okteto.com> * DEV-828: Format correctly file Signed-off-by: Nacho Fuertes <nacho@okteto.com> --------- Signed-off-by: Nacho Fuertes <nacho@okteto.com> (cherry picked from commit 435f27a)
ifbyol
added a commit
that referenced
this pull request
Dec 10, 2024
* DEV-828: Removed check on integration tests to simulate error case Signed-off-by: Nacho Fuertes <nacho@okteto.com> * DEV-828: Don't allow empty strings as tests containers to run Signed-off-by: Nacho Fuertes <nacho@okteto.com> * DEV-828: Format correctly file Signed-off-by: Nacho Fuertes <nacho@okteto.com> --------- Signed-off-by: Nacho Fuertes <nacho@okteto.com> (cherry picked from commit 435f27a) Co-authored-by: Ignacio Fuertes <nacho@okteto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
DEV-828
Don't allow to execute empty test containers names. We were not filtering empty strings as part of the arguments, so when an empty strings comes (for example, from the GitHub action), it is failing with the error
Don't know what to do with "".So, we skip empty strings
This part of the code doesn't have unit tests, and I was changing integration tests, but I realized we are not running them never, so I will need to perform more changes. In order to have this fixed as soon as possible I will send a follow up PR, but I want to include this in the
3.2release branchHow to validate
Having the following manifest:
okteto test "", you will get the error