8000 fix cves by maroshii · Pull Request #4636 · okteto/okteto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix cves #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 7, 2025
Merged

fix cves #4636

merged 5 commits into from
Jan 7, 2025

Conversation

maroshii
Copy link
Contributor
@maroshii maroshii commented Jan 3, 2025

No description provided.

@maroshii maroshii added release/internal backport release-3.7 Backport this PR to CLI versions 3.7 labels Jan 3, 2025
@maroshii maroshii requested a review from a team as a code owner January 3, 2025 18:06
@codecov Codecov
Copy link
codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.81%. Comparing base (9f4a35b) to head (a14da41).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4636   +/-   ##
=======================================
  Coverage   47.81%   47.81%           
=======================================
  Files         371      371           
  Lines       29830    29830           
=======================================
  Hits        14263    14263           
  Misses      14471    14471           
  Partials     1096     1096

jLopezbarb
jLopezbarb reviewed Jan 7, 2025
View reviewed changes
Dockerfile
ARG SYNCTHING_VERSION=1.28.0
ARG KUBECTL_VERSION=1.30.8
ARG HELM_VERSION=3.16.4
ARG SYNCTHING_VERSION=1.28.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to modify it here:

okteto/pkg/syncthing/install.go

Line 33 in 9f4a35b

syncthingVersion = "1.28.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jLopezbarb jLopezbarb mentioned this pull request Jan 7, 2025
Merged
@maroshii maroshii merged commit d57ad21 into master Jan 7, 2025
13 checks passed
@maroshii maroshii deleted the fran/fix-cves branch January 7, 2025 13:04
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
@github-actions
fix cves (#4636)
a2d6eeb 
* fix cves

* update okteto/pkg/syncthing/install.go

* bump syncthing to 1.29

* bump remote to 0.6.2

* revert syncthing update

(cherry picked from commit d57ad21)
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Merged
maroshii pushed a commit that referenced this pull request Jan 7, 2025
@github-actions
fix cves (#4636) (#4638)
1cabd5b 
* fix cves

* update okteto/pkg/syncthing/install.go

* bump syncthing to 1.29

* bump remote to 0.6.2

* revert syncthing update

(cherry picked from commit d57ad21)

Co-authored-by: Francisco Miranda <fran@okteto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jLopezbarb jLopezbarb jLopezbarb left review comments

@ifbyol ifbyol ifbyol approved these changes

Assignees
No one assigned
Labels
backport release-3.7 Backport this PR to CLI versions 3.7 release/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maroshii @ifbyol @jLopezbarb
0