8000 remove security context and fsgroup on initialization by jLopezbarb · Pull Request #4640 · okteto/okteto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove security context and fsgroup on initialization #4640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

remove security context and fsgroup on initialization #4640

merged 1 commit into from
Jan 9, 2025

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier Lopez javier@okteto.com

Proposed changes

Fixes an issue where certain images couldn't start (rabbitmq:3.13.0-management) because there is a check that make usre the user is the same as the first one.

How to validate

  1. Deploy the following compose file:
services:
  queue:
    image: rabbitmq:3.13.0-management
    ports:
      - 5672
      - 15672
    volumes:
      - /var/lib/rabbitmq
    healthcheck:
      interval: 10s
      timeout: 1m
      retries: 5
      start_period: 3s
      test: rabbitmq-diagnostics -q ping%
  1. Run okteto destroy
  2. Run okteto deploy
  3. See that the queue service can start

CLI Quality Reminders 🔧

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

@jLopezbarb
37b8c65 
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner January 8, 2025 12:38
@codecov Codecov
Copy link
codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.80%. Comparing base (d57ad21) to head (37b8c65).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4640      +/-   ##
==========================================
- Coverage   47.81%   47.80%   -0.02%     
==========================================
  Files         371      371              
  Lines       29830    29823       -7     
==========================================
- Hits        14263    14256       -7     
  Misses      14471    14471              
  Partials     1096     1096

@jLopezbarb jLopezbarb added backport release-3.6 Backport this PR to CLI versions 3.6 backport release-3.7 Backport this PR to CLI versions 3.7 release/bug-fix and removed release/internal labels Jan 8, 2025
@jLopezbarb jLopezbarb merged commit 2bd6a5e into master Jan 9, 2025
36 of 37 checks passed
@jLopezbarb jLopezbarb deleted the jlo/revert-all-rootless-cli branch January 9, 2025 10:14
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@jLopezbarb @github-actions
remove security context and fsgroup on initialization (#4640)
a053e48 
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit 2bd6a5e)
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@jLopezbarb @github-actions
remove security context and fsgroup on initialization (#4640)
6ee8b89 
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit 2bd6a5e)
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
jLopezbarb added a commit that referenced this pull request Jan 9, 2025
@github-actions @jLopezbarb
remove security context and fsgroup on initialization (#4640) (#4644)
976e119 
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit 2bd6a5e)

Co-authored-by: Javier López Barba <javier@okteto.com>
jLopezbarb added a commit that referenced this pull request Jan 9, 2025
@github-actions @jLopezbarb
remove security context and fsgroup on initialization (#4640) (#4643)
8a8beb9 
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit 2bd6a5e)

Co-authored-by: Javier López Barba <javier@okteto.com>
@BrewTestBot BrewTestBot mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbyol ifbyol ifbyol approved these changes

Assignees
No one assigned
Labels
backport release-3.6 Backport this PR to CLI versions 3.6 backport release-3.7 Backport this PR to CLI versions 3.7 release/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jLopezbarb @ifbyol
0