8000 feat(wait-for): add wait-for command and parser for service dependencies in compose by jLopezbarb · Pull Request #4685 · okteto/okteto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(wait-for): add wait-for command and parser for service dependencies in compose #4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

feat(wait-for): add wait-for command and parser for service dependencies in compose #4685

wants to merge 9 commits into from

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier Lopez javier@okteto.com

Proposed changes

Creates a new wait for command that waits for a specific resource to be in the specific condition. When creating a compose service it checks if the feature flag is enabled and if it is enabled we deploy a new init contaner waiting for each of the dependencies.

How to validate

  1. Deploy a compose file
  2. Sleep namespace
  3. Wake up and check that the resources wakes up in the correct order

CLI Quality Reminders 🔧

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

@jLopezbarb
feat(wait-for): add wait-for command and parser for service dependenc…
c314c47 
…ies in compose

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner March 14, 2025 17:24
@jLopezbarb jLopezbarb marked this pull request as draft March 14, 2025 17:24
@jLopezbarb
feat(wait-for): enable conditional waiting for service dependencies i…
1c2c1fb 
…n stack

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb
feat(wait-for): refactor command and parser for improved readability …
533491c 
…and maintainability

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb
refactor(wait-for): simplify goroutine handling and improve error rep…
ce62c79 
…orting

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb
fix(wait-for): improve error messaging for detected errors and unsupp…
9378ad9 
…orted conditions

Signed-off-by: Javier Lopez <javier@okteto.com>
ifbyol
ifbyol reviewed Mar 18, 2025
View reviewed changes
@jLopezbarb
address comments
e2517b3 
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb
chore(tests): add license header to crud_test.go
3e42fef 
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb
chore(tests): fix license header formatting in crud_test.go
ae542fe 
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb
fix(tests): unit tests
903603e 
Signed-off-by: Javier Lopez <javier@okteto.com>
@codecov Codecov
Copy link
codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.61151% with 179 lines in your changes missing coverage. Please review.

Project coverage is 48.59%. Comparing base (dd62f76) to head (903603e).
Report is 4 commits behind head on master.

❌ Your patch status has failed because the patch coverage (35.61%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4685      +/-   ##
==========================================
- Coverage   48.76%   48.59%   -0.18%     
==========================================
  Files         354      357       +3     
  Lines       29401    29673     +272     
==========================================
+ Hits        14338    14420      +82     
- Misses      13932    14115     +183     
- Partials     1131     1138       +7
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jLopezbarb
Copy link
Contributor Author

Closing in favour of #4686

@jLopezbarb jLopezbarb closed this Mar 24, 2025
@jLopezbarb jLopezbarb deleted the jlo/depends_on_by_command branch March 24, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbyol ifbyol ifbyol left review comments

Assignees
No one assigned
Labels
release/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jLopezbarb @ifbyol
0