Add context command initialization in restart command #4692
Conversation
Signed-off-by: Javier Lopez <javier@okteto.com>
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #4692 +/- ##
==========================================
- Coverage 48.77% 48.77% -0.01%
==========================================
Files 354 354
Lines 29468 29472 +4
==========================================
Hits 14374 14374
- Misses 13950 13954 +4
Partials 1144 1144 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
This is an improvement compared with what we have, but this doesn't work well. For example, if you don't specify the flag namespace, it looks the pod through all the namespaces, as the namespace value is "", instead of using the default one from the context.
Could you at least fix that to prevent accidentally to restart services you should not to?
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez javier@okteto.com
Proposed changes
We were not initialising the context for the restart command making it fail if used by any user. This ensures the context is initialised and can create a k8s config for the client
CLI Quality Reminders 🔧
For both authors and reviewers: