8000 fix: start spinner when buidlkit fails to connect by jLopezbarb · Pull Request #4693 · okteto/okteto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: start spinner when buidlkit fails to connect #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix: start spinner when buidlkit fails to connect #4693

merged 1 commit into from
Apr 1, 2025

Conversation

jLopezbarb
Copy link
Contributor

Proposed changes

Show the waiting for buildkit connection only when it fails for first time.

How to validate

  1. Run export OKTETO_DISABLE_SPINNER=false
  2. Run okteto build
  3. Check that the message is not shown (if buildkit is up and running) and the build happens correctly

CLI Quality Reminders 🔧

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

@jLopezbarb
fix: start spinne when buidlkit fails to connect
d52452d 
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner March 28, 2025 12:30
@jLopezbarb jLopezbarb added release/bug-fix backport release-3.6 Backport this PR to CLI versions 3.6 labels Mar 28, 2025
@codecov Codecov
Copy link
codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.78%. Comparing base (4a6454f) to head (d52452d).
Report is 1 commits behind head on master.

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4693      +/-   ##
==========================================
- Coverage   48.78%   48.78%   -0.01%     
==========================================
  Files         354      354              
  Lines       29474    29476       +2     
==========================================
  Hits        14380    14380              
- Misses      13951    13952       +1     
- Partials     1143     1144       +1
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jLopezbarb jLopezbarb merged commit d07390e into master Apr 1, 2025
22 of 23 checks passed
@jLopezbarb jLopezbarb deleted the jlo/fix-buildkit-waiting-message branch April 1, 2025 12:37
github-actions bot pushed a commit that referenced this pull request Apr 1, 2025
@jLopezbarb @github-actions
fix: start spinne when buidlkit fails to connect (#4693)
a326bfa 
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit d07390e)
@github-actions github-actions bot mentioned this pull request Apr 1, 2025
Merged
jLopezbarb added a commit that referenced this pull request Apr 7, 2025
@github-actions @jLopezbarb
fix: start spinne when buidlkit fails to connect (#4693) (#4694)
2a2f3ab 
Signed-off-by: Javier Lopez <javier@okteto.com>
(cherry picked from commit d07390e)

Co-authored-by: Javier López Barba <javier@okteto.com>
@BrewTestBot BrewTestBot mentioned this pull request May 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbyol ifbyol ifbyol approved these changes

Assignees
No one assigned
Labels
backport release-3.6 Backport this PR to CLI versions 3.6 release/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jLopezbarb @ifbyol
0