8000 Adds the flag for redeploying dependencies in pipeline and preview dependencies. by jLopezbarb · Pull Request #4715 · okteto/okteto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds the flag for redeploying dependencies in pipeline and preview dependencies. #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2025
Merged

Adds the flag for redeploying dependencies in pipeline and preview dependencies. #4715

merged 6 commits into from
May 14, 2025

Conversation

jLopezbarb
Copy link
Contributor

Proposed changes

Fixes DEV-895

Adds the flag for redeploying dependencies in pipeline and preview dependencies. Adds retrocompatibility with labels and clusters without the graphql dependencies endpoint

How to validate

  1. Deploy https://github.com/jLopezbarb/hello-world-chart.git
  2. Redeploy using okteto pipeline deploy --dependencies
  3. Check that it redeploys dependencies and not shown skipping dependencies

CLI Quality Reminders 🔧

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

jLopezbarb added 3 commits May 8, 2025 17:11
@jLopezbarb
add redeploy dependencies to the pipeline and preview
7370c8a 
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb
fix: remove "dependencies" argument from deploy pipeline and preview …
2a807c4 
…mutations

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb
fix: update mutation type in DeployPreview to use deployPreviewMutati…
3b3e602 
…onWithLabels

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner May 12, 2025 10:46
@jLopezbarb
fix: update DeployPreview to use mutationWithoutDependencies response
279486f 
Signed-off-by: Javier Lopez <javier@okteto.com>
@codecov Codecov
Copy link
codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.13187% with 29 lines in your changes missing coverage. Please review.

Project coverage is 48.83%. Comparing base (9a308d2) to head (2b955f5).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4715      +/-   ##
==========================================
- Coverage   48.86%   48.83%   -0.04%     
==========================================
  Files         354      354              
  Lines       29527    29572      +45     
==========================================
+ Hits        14429    14442      +13     
- Misses      13952    13981      +29     
- Partials     1146     1149       +3
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ifbyol
ifbyol reviewed May 13, 2025
View reviewed changes
Copy link
Member
@ifbyol ifbyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is a problem with the deploy preview command. The flag doesn't work fine

Screenshot 2025-05-13 at 09 43 22

jLopezbarb added 2 commits May 13, 2025 13:03
@jLopezbarb
fix: update DeployPreview to handle dependencies argument correctly
e54c00c 
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb
fix: update redeployDependencies flag description for clarity
2b955f5 
Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb merged commit a3fc450 into master May 14, 2025
12 of 13 checks passed
@jLopezbarb jLopezbarb deleted the jlo/dev-895 branch May 14, 2025 09:21
@BrewTestBot BrewTestBot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbyol ifbyol ifbyol approved these changes

Assignees
No one assigned
Labels
release/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jLopezbarb @ifbyol
0