feat: implement AutoDown functionality with tests #4732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added AutoDown feature to automatically handle down operations based on the OKTETO_AUTO_DOWN_ENABLED environment variable. - Introduced `autoDownRunner` struct to encapsulate the AutoDown logic. - Created unit tests for AutoDown behavior, including scenarios for enabled and disabled states. - Updated interfaces and methods to support the new functionality, ensuring proper integration with existing components. This enhancement improves the user experience by automating down operations when desired. Signed-off-by: Javier Lopez <javier@okteto.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4732 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 354 355 +1
Lines 29718 29759 +41
=======================================
+ Hits 14521 14543 +22
- Misses 14040 14055 +15
- Partials 1157 1161 +4 🚀 New features to boost your workflow:
|
ifbyol
reviewed
Jun 17, 2025
There was a problem hiding this comment.
Functionality looks good, but as we discussed in the daily, it is not clear in which cases we should stop the dev container or not, so let's record a couple of videos with the experience and share it with the product team to avoid confusions in the different scenarios
- Adjusted the error handling logic in the AutoDown functionality to ensure proper logging of exit signals. - The error check for the AutoDown execution was moved to improve clarity and maintainability. This change enhances the robustness of the AutoDown feature by ensuring that errors are logged appropriately before returning from the function. Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez <javier@okteto.com>
Co-authored-by: Cody J Landstrom <cody.landstrom@gmail.com>
ifbyol
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes PROD-16
autoDownRunnerstruct to encapsulate the AutoDown logic.How to validate
OKTETO_AUTO_DOWN_ENABLED. exportOKTETO_AUTO_DOWN_ENABLED=trueokteto upon an interactive session (bash,sh)okteto upon a command (yarn start,sleep 100000)CTRL + Cand check that the session has gone downCLI Quality Reminders 🔧
For both authors and reviewers: