8000 Add support for more commands by henrikwidlund · Pull Request #323 · ol-iver/denonavr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for more commands #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 81 commits into from
May 1, 2025
Merged

Add support for more commands #323

merged 81 commits into from
May 1, 2025

Conversation

henrikwidlund
Copy link
Contributor
@henrikwidlund henrikwidlund commented Mar 9, 2025 •
edited
Loading

Adds support for the following:

Audyssey

  • LFC
  • Containment Amount

DenonAVR

  • Improved Settings Menu toggle
  • Dimmer
  • Auto Standby
  • Sleep
  • Delay and Delay Time
  • Eco Mode
  • HDMI Output
  • HDMI Audio Decode
  • Video Processing Mode
  • Tactile Transducer
  • Room Size
  • Triggers
  • Speaker Preset
  • Bluetooth Transmitter and Output Mode
  • Audio Restorer
  • Status Display (Denon only)
  • System Reset
  • Network Restart
  • Remote Control and Panel Lock
  • Quick Select and Quick Select Memory (programs a Quick Select)

Dirac

  • Dirac Filter

Sound Mode

  • Sound Mode Next/Previous
  • Neural:X Toggle
  • IMAX Toggle
  • IMAX Audio Settings Toggle
  • IMAX Low and High Pass Filter
  • IMAX Subwoofer Output Mode
  • Cinema EQ Toggle
  • Center Spread Toggle
  • Loudness Management Toggle
  • Dialog Enhancer
  • Auro-Matic 3D Preset
  • Auro-Matic 3D Strength
  • Auro 3D mode
  • Dialog Control
  • Speaker Virtualizer
  • Effect Speaker Selection

Volume

  • Channel Volumes
  • Reset All Channel Volumes
  • Subwoofer On/Off
  • Subwoofer Level
  • LFE Volume
  • Bass Sync

@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch 2 times, 8000 most recently from c0515b6 to dd2097a Compare March 9, 2025 15:55
@henrikwidlund
Add support for more commands
66586a4 
Commands added:
- Dimmer Control
- Channel Level Control
- Audio Delay Control
- Dirac Filter Control
- Eco Mode Control
- Audyssey LFC Control
- HDMI Output Control
- Status Display
- Surround Mode Next/Previous
@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch 2 times, most recently from 12217e4 to 66586a4 Compare March 9, 2025 16:03
@henrikwidlund
Copy link
Contributor Author

@ol-iver what should I do about the problems with Literal in the tests? Replace them with Enum?

@ol-iver
Copy link
Owner
ol-iver commented Mar 16, 2025

@ol-iver what should I do about the problems with Literal in the tests? Replace them with Enum?

I'll remove support for python 3.7. It is EOL anyway.

@henrikwidlund
Copy link
Contributor Author

Damnit, I missed your comment and now I pushed the changes. Do you want me to revert it?

@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch from b1a19cc to 43fe7c3 Compare March 16, 2025 17:50
@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch from 43fe7c3 to 01f8b79 Compare March 16, 2025 17:52
@henrikwidlund
Copy link
Contributor Author

If anyone had any doubts, the number of commits to fix linting should tell you that I'm not a Python developer 😅

@ol-iver
Copy link
Owner
ol-iver commented Mar 16, 2025 •
edited
Loading

Damnit, I missed your comment and now I pushed the changes. Do you want me to revert it?

Please give it a try 👍
I just removed Python 3.7 in main branch.

@henrikwidlund
Copy link
Contributor Author
henrikwidlund commented Mar 16, 2025 •
edited
Loading

Damnit, I missed your comment and now I pushed the changes. Do you want me to revert it?

Please give it a try 👍 I just removed Python 3.7 in main branch.

Done. Just realized that I could create literals in the const file to not have to duplicate the definitions, that would also work for the channel enum, but I'm not sure about that one as the channel names are a bit hard to understand the acronyms, that's the reason I chose to use enums for those two types, DimmerMode is kind of understandable I guess.

@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch from 203d5d6 to fe8c2f5 Compare March 30, 2025 12:56
@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch from fe8c2f5 to c2b9f5b Compare March 30, 2025 13:00
@henrikwidlund
Copy link
Contributor Author
henrikwidlund commented Mar 30, 2025 •
edited
Loading


@ol-iver okay, now I'm done. I've implemented all the commands in the specification for AVC-A10H except:

  • A/B Speaker toggle (switch off front right/left channel)
  • Effect (don't know what this even is)
  • Zone 2 and 3 ( I don't use them, so can't confirm if it'd work. Should be easy for someone else to implement if requested)
    • Quick Select
    • Auto Standby
    • Stereo/Mono
    • Front levels
    • High Pass Filter
    • Sleep
    • HDMI Audio

@henrikwidlund
Copy link
Contributor Author

Okay, realized I could use bool instead of returning ON/OFF, now I'm out of ideas :)

@henrikwidlund
Copy link
Contributor Author
henrikwidlund commented Apr 6, 2025 •
edited
Loading

@ol-iver I have an idea for how to get some of the toggle commands working via http. The api supports sending IR commands to it by sending the identifiers for the IR command. There isn't an IR command for everything, but the settings and other stuff should work. I'm not going to do this a part of this PR because it's already bigger than what I would consider ok (sorry about that).

Edit: They still don't toggle, only the mute command does, and that one I think is already working with HTTP?

@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch from e57687e to 674c58e Compare April 13, 2025 19:06
@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch from 674c58e to 7e6c265 Compare April 17, 2025 09:48
@henrikwidlund henrikwidlund requested a review from ol-iver April 17, 2025 09:49
ol-iver
ol-iver approved these changes May 1, 2025
View reviewed changes
Copy link
Owner
@ol-iver ol-iver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a crazy amount of commands and properties, awesome 🚀

Are you using home-assistant? Maybe they could be added as services/additional entities. I'm not sure what's the best way there though since I did not do any bigger contributions lately.

@ol-iver
Copy link
Owner
ol-iver commented May 1, 2025

Edit: They still don't toggle, only the mute command does, and that one I think is already working with HTTP?

IIRC the mute command does not toggle perfectly with HTTP since there must be an async_update to get the new state that you can toggle it the other way again.
But yes, this PR is already big enough 😅

@ol-iver
Copy link
Owner
ol-iver commented May 1, 2025

Btw., I'm sorry that it took so long. I did not spend so much time here recently.

@ol-iver ol-iver merged commit af943b9 into ol-iver:main May 1, 2025
7 checks passed
@henrikwidlund
Copy link
Contributor Author

I don't use home assistant, I use this on my remote (Unfolded Circle).

No worries with the delay, we all have work and private life that needs to take priority first

@ol-iver
Copy link
Owner
ol-iver commented May 1, 2025

The remote looks good, I'm gonna check it out.

I'm gonna cut a new release soon, that you can use your work here 😄

@henrikwidlund henrikwidlund deleted the feature/more_commands branch May 1, 2025 16:10
@henrikwidlund
Copy link
Contributor Author

Awesome, thanks! Once released I'll do a PR to the Denon integration driver with the changes :)

@ol-iver ol-iver mentioned this pull request May 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ol-iver ol-iver ol-iver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrikwidlund @ol-iver
0