Windows install #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The main change is to src/Makevars.win : * it supports biarch (ie both 32 bit and 64 bit) installs on Windows * it accepts and uses either DLL (dynamic linked library) or static versions of the FFTW libraries, * if DLLs are provided, it copies them to the (appropriate sub-directory of the) Rcartogram directory in the users R library, at install time * it discovers whether the fftw3 library is called libfftw3.something, or libfftw3-3.something, and provides the correct value (fftw3 or fftw3-3) in the -l flag to the link step * it can be used to create a Windows binary versions of Rcartogram using the Win-Builder website service, at http://win-builder.r-project.org/ * it accepts 3 alternative environment or make variables in order to learn where the fftw3 libraries are. In order of decreasing preference (ie the first one found is used), they are: + LIB_FFTW - this is the name of the make variable that the Win-Builder website service provides to point to the fftw3 header and libraries + local_LIB_FFTW - this is the name of an environment variable that a package installer can set to point to their local copies of the fftw3 libraries. It's value should point to a directory which has 2 sub-directories, namely /i386 (containing the 32 bit version of the fftw3 library) and /x64 (containing the 64 bit version of the fftw3 library) + FFTW3_DIR - this is equivalent to local_LIB_FFTW, and is supported for compatibility with earlier versions of Makevars.win * the fftw3.h header file and libfftw3 library file can either both be in the same sub-directory (eg /i386), or may be in sub-sub-directories (eg in /i386/include and /i386/lib). Likewise for /x64. * it emits messages informing the user what it has done * it is heavily commented, in case a novice user wants to understand how it works 2. configure.win has been altered : * it no longer copies the fftw3 DLLs (src/Makevars.win now does that, only if necessary) * it emits a more expansive set of instructions if the environment variables pointing to the fftw3 library are absent.
…..) in predict.Cartogram Probably due to some interaction between .Call and *only* copy-on-modify in the former line ans = list(x = tmp, y = tmp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request affects several files. It is about installing Rcartogram from source on Windows.
The main change is to src/Makevars.win:
configure.win has been altered :
README.WindowsInstall has been created:
The DESCRIPTION file:
A vignette called vignettes/README.WindowsInstall.Tutorial.Rmd (also provided in html format) has been added.
Finally, in R/cart.R