Max block attachments option #2190
Merged
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to set a maximum number of attachments allowed in a block. A developer would set
$maxAttahmentswhen calling theblockAttachmentsForm()view helper. It's more of a superficial maximum, rather than an enforced one, because it simply hides the "Add attachment" button when the number of attachments reaches the maximum. It also hides the bulk add controls in the sidebar if a maximum is set.The use case I'm working on that needs this feature is the ImageAnnotate module. I would like there to be a way to prevent more than one attachment on the block: one block, one image to annotate.