This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Fix: quit the application with Cmd + Q #2404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2404 +/- ##
==========================================
+ Coverage 38.19% 38.24% +0.04%
==========================================
Files 300 300
Lines 12522 12525 +3
Branches 1649 1650 +1
==========================================
+ Hits 4783 4790 +7
+ Misses 7484 7480 -4
Partials 255 255
Continue to review full report at Codecov.
|
CrossR
approved these changes
Jul 8, 2018
There was a problem hiding this comment.
Changes look good, and gave it a quick test on mac and it worked well!
Thanks for adding the unit tests too, will be useful to make sure this functionality isn't changed by mistake in the future!
Just waiting on a flaky CI test to pass, then this can be merged.
|
@CrossR thank you for reviewing 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no
3099
changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mac we should quit the application when the user press Cmd + Q.
Currently we need to use Cmd + Q twice to quit the application.
This PR fixes it.