8000 Bugfix/close tooltip on scroll by akinsho · Pull Request #2428 · onivim/oni · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Bugfix/close tooltip on scroll #2428

Merged
merged 12 commits into from
Jul 16, 2018
Merged

Bugfix/close tooltip on scroll #2428

merged 12 commits into from
Jul 16, 2018

Conversation

akinsho
Copy link
Member
@akinsho akinsho commented Jul 15, 2018 •
edited
Loading

Following #2143, as discussed in #2138 I've added an onBufferScrolled subscription which dispatches the onHideHover and onHideDefinition events so that the definition and tooltip are correctly closed on scroll.

I know there was some discussion re options @bryphe i.e either dispatching a scroll action or directly dispatching the events. I opted for the easier/lazier solution of directly dispatching the events, let me know if you'd prefer an action although I'm not entirely certain how the LanguageStore works so opted for a solution that wouldn't risk breaking it

Fixes #2138

@codecov
Copy link
codecov bot commented Jul 15, 2018

Codecov Report

Merging #2428 into master will decrease coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2428      +/-   ##
==========================================
- Coverage    38.3%   38.28%   -0.03%     
==========================================
  Files         300      300              
  Lines       12540    12539       -1     
  Branches     1651     1651              
==========================================
- Hits         4804     4801       -3     
- Misses       7481     7483       +2     
  Partials      255      255
Impacted Files Coverage Δ
...src/Services/Language/LanguageEditorIntegration.ts 81.03% <60%> (-3.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca5847...0c38a6b. Read the comment docs.

bryphe
bryphe approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member
@bryphe bryphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Akin909 ! Thanks for doing this - important fit & finish fix 💯

@akinsho akinsho merged commit cdd2224 into onivim:master Jul 16, 2018
@akinsho akinsho deleted the bugfix/close-tooltip-scroll branch July 16, 2018 21:56
@akinsho akinsho mentioned this pull request Jul 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryphe bryphe bryphe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hover tooltip and Definitions move on scroll
2 participants
@akinsho @bryphe
0