This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Bugfix/buffer scrollbar fixes #2495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because position fixed does not respect overflow
Codecov Report
@@ Coverage Diff @@
## master #2495 +/- ##
==========================================
+ Coverage 44.2% 44.24% +0.04%
==========================================
Files 344 345 +1
Lines 13886 13937 +51
Branches 1829 1830 +1
==========================================
+ Hits 6138 6167 +29
- Misses 7508 7530 +22
Partials 240 240
Continue to review full report at Codecov.
|
separate out marker creation into a separate method add keys to error markers
|
would appreciate a review @CrossR or @TalAmuyal, this fixes a UI issue which was really annoying me which is that there was a lag when resizing the window so the scrollbar would visibly be slow to move when resizing the original issue has a GIF also fixed an issue where error markers weren't being shown properly on the scrollbar |
CrossR
approved these changes
Aug 19, 2018
psxpaul
pushed a commit
to psxpaul/oni
that referenced
this pull request
Aug 20, 2018
This PR fixes onivim#2114 and a few issues with the buffer scroll bar The first issue relates to onivim#2114 which was the fact the the buffer bar lagged behind if the window was resized. The specific change that fixes this is changing the position from `absolute` to `fixed` The other issue was that the error markers weren't rendering correctly i.e. only one error marker was shown in the buffer because the `uniqBy` function was filtering by Id but actually there was no id prop. Ive changed this to filter by line so the scroll bar just shows errors by line, meaning you now get multiple errors in the scroll bar based on position Also took the opportunity to change the components to styled components with dynamic attrs and added keys to the error components
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2114 and a few issues with the buffer scroll bar
The first issue relates to #2114 which was the fact the the buffer bar lagged behind if the window was resized. The specific change that fixes this is changing the position from
absolutetofixedThe other issue was that the error markers weren't rendering correctly i.e. only one error marker was shown in the buffer because the
uniqByfunction was filtering by Id but actually there was no id prop. Ive changed this to filter by line so the scroll bar just shows errors by line, meaning you now get multiple errors in the scroll bar based on positionAlso took the opportunity to change the components to styled components with dynamic attrs and added keys to the error components