8000 Fix for 2272 - <f12> opens in current tab by psxpaul · Pull Request #2504 · onivim/oni · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Fix for 2272 - <f12> opens in current tab #2504

Merged
merged 1 commit into from
Aug 19, 2018
Merged

Fix for 2272 - <f12> opens in current tab #2504

merged 1 commit into from
Aug 19, 2018

Conversation

psxpaul
Copy link
Contributor
@psxpaul psxpaul commented Aug 14, 2018 •
edited
Loading

This is a fix for #2272 to make language.gotoDefinition use the Oni.DefaultFileOpenOptions.openMode setting by default. It also adds:

  • language.gotoDefinition.openNewTab
  • language.gotoDefinition.openEdit
  • language.gotoDefinition.openExistingTab

so that users can create bindings for the specific behavior they want.

@codecov
Copy link
codecov bot commented Aug 14, 2018 •
edited
Loading

Codecov Report

Merging #2504 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2504      +/-   ##
==========================================
+ Coverage    44.2%   44.22%   +0.01%     
==========================================
  Files         344      344              
  Lines       13886    13882       -4     
  Branches     1829     1828       -1     
==========================================
+ Hits         6138     6139       +1     
+ Misses       7508     7503       -5     
  Partials      240      240
Impacted Files Coverage Δ
...er/src/Editor/NeovimEditor/NeovimEditorCommands.ts 12.28% <0%> (+0.95%) ⬆️
browser/src/Editor/NeovimEditor/Definition.ts 31.57% <0%> (+9.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a54bb2c...ad97734. Read the comment docs.

akinsho
akinsho approved these changes Aug 19, 2018
View reviewed changes
Copy link
Member
@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psxpaul sorry for the delay reviewing this, looks good to me 👍

@akinsho akinsho merged commit dd4b33d into onivim:master Aug 19, 2018
@badosu badosu mentioned this pull request Aug 20, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an a 5EA2 ccount? Sign in.
Reviewers

@akinsho akinsho akinsho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psxpaul @akinsho
0