Convenience function get_const_tensor #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 74.51% 74.49% -0.03%
==========================================
Files 37 37
Lines 4595 4634 +39
Branches 933 946 +13
==========================================
+ Hits 3424 3452 +28
- Misses 826 832 +6
- Partials 345 350 +5 ☔ View full report in Codecov by Sentry. |
|
@codecov-ai-reviewer test |
|
On it! Codecov is generating unit tests for this PR. |
Merged
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
898a6c6 to
4fec7af
Compare
This PR adds tests for #45 ### Commits: - Add unit tests for get_constant_tensor function This commit adds a new test file to validate the newly added get_constant_tensor function. The tests cover various scenarios including direct constant values, values without producer nodes, values with non-Constant producer nodes, and values produced by Constant nodes with different attribute types (float, int, tensor). --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: codecov-ai[bot] <156709835+codecov-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
commented
Jun 17, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
titaiwangms
approved these changes
Jun 17, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the constant tensor from a value, if it exists.
A constant tensor can be obtained if the value has a
const_valueset(as in the case of an initializer) or if the value is produced by a
Constant node.
This function will not alter the
const_valueof the value, butit will propagate the shape and type of the constant tensor to the value
if
propagate_shape_typeis set to True.