8000 Add RMSNormalization to ONNX opset 23 by shubhambhokare1 · Pull Request #6443 · onnx/onnx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add RMSNormalization to ONNX opset 23 #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Feb 21, 2025
Merged

Add RMSNormalization to ONNX opset 23 #6443

merged 21 commits into from
Feb 21, 2025

Conversation

shubhambhokare1
Copy link
Contributor
@shubhambhokare1 shubhambhokare1 commented Oct 9, 2024 •
edited
Loading

Description

Add the following key LLM ops to the ONNX standard

  • RMSNormalization

Motivation and Context

Standardize Operators that are showing up in key LLM models.

@shubhambhokare1 shubhambhokare1 requested a review from a team as a code owner October 9, 2024 20:39
justinchuby
justinchuby reviewed Oct 9, 2024
View reviewed changes
justinchuby
justinchuby reviewed Oct 9, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 9, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 9, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 9, 2024
View reviewed changes
justinchuby
justinchuby reviewed Oct 9, 2024
View reviewed changes
@codecov Codecov
Copy link
codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.42105% with 68 lines in your changes missing coverage. Please review.

Project coverage is 57.13%. Comparing base (783ed42) to head (0e7f41c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
onnx/backend/test/case/node/rmsnormalization.py 0.00% 66 Missing ⚠️
onnx/reference/ops/op_rms_normalization.py 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6443      +/-   ##
==========================================
- Coverage   57.21%   57.13%   -0.09%     
==========================================
  Files         505      507       +2     
  Lines       31832    31927      +95     
  Branches     3031     3040       
8000
+9     
==========================================
+ Hits        18213    18240      +27     
- Misses      12797    12864      +67     
- Partials      822      823       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 11, 2024
View reviewed changes
@gramalingam
Copy link
Contributor

@shubhambhokare1 : can you please add links for papers or other sources for the definition of these functions? Would be helpful.

@shubhambhokare1 shubhambhokare1 changed the title [WIP] Add LLM ops to ONNX opset 23 [WIP] Add LLM ops (normalizations) to ONNX opset 23 Oct 14, 2024
shubhambhokare1
shubhambhokare1 commented Oct 15, 2024
View reviewed changes 8000
@shubhambhokare1 shubhambhokare1 changed the title [WIP] Add LLM ops (normalizations) to ONNX opset 23 Add LLM ops (normalizations) to ONNX opset 23 Oct 17, 2024
justinchuby
justinchuby reviewed Oct 19, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 22, 2024
View reviewed changes
gramalingam
gramalingam reviewed Oct 22, 2024
View reviewed changes
gramalingam
67ED gramalingam reviewed Oct 22, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 31, 2025
View reviewed changes
@shubhambhokare1
fix syntax in shape inference
8ca6eee 
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 31, 2025
View reviewed changes
@shubhambhokare1
fix lint
9322e0f 
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
@shubhambhokare1 shubhambhokare1 mentioned this pull request Feb 1, 2025
Closed
gramalingam
gramalingam reviewed Feb 15, 2025
View reviewed changes
gramalingam
gramalingam reviewed Feb 15, 2025
View reviewed changes
gramalingam
gramalingam reviewed Feb 15, 2025
View reviewed changes
gramalingam
gramalingam reviewed Feb 15, 2025
View reviewed changes
gramalingam
gramalingam reviewed Feb 15, 2025
View reviewed changes
gramalingam
gramalingam reviewed Feb 15, 2025
View reviewed changes
@shubhambhokare1
nit changes
47f58b6 
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
@shubhambhokare1
add shape inf check
0e7f41c 
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
@justinchuby justinchuby added this pull request to the merge queue Feb 21, 2025
@justinchuby justinchuby added topic: operator Issues related to ONNX operators release notes Important changes to call out in release notes labels Feb 21, 2025
Merged via the queue into onnx:main with commit db4ab3f Feb 21, 2025
56 of 57 checks passed
@botantony botantony mentioned this pull request May 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby left review comments

@xadupre xadupre xadupre left review comments

@nzmora-nvidia nzmora-nvidia nzmora-nvidia left review comments

@yuanyao-nv yuanyao-nv yuanyao-nv left review comments

@gramalingam gramalingam gramalingam approved these changes

Assignees
No one assigned
Labels
release notes Important changes to call out in release notes topic: operator Issues related to ONNX operators
Projects
PR Tracker
Status: Done
Milestone
1.18
Development

Successfully merging this pull request may close these issues.
8 participants
@shubhambhokare1 @gramalingam @WilliamTambellini @justinchuby @xadupre @nzmora-nvidia @yuanyao-nv @andife
0