8000 Fix extra-semi-stmt warnings by cyyever · Pull Request #6771 · onnx/onnx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix extra-semi-stmt warnings #6771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 14, 2025
Merged

Fix extra-semi-stmt warnings #6771

merged 11 commits into from
Jun 14, 2025

Conversation

cyyever
Copy link
Contributor
@cyyever cyyever commented Mar 8, 2025

Description

Fix extra-semi-stmt warnings.

Motivation and Context

Better code.

@cyyever cyyever requested review from a team as code owners March 8, 2025 02:15
@github-project-automation github-project-automation bot moved this to In progress in PR Tracker Mar 8, 2025
@cyyever cyyever marked this pull request as draft March 8, 2025 02:22
@cyyever cyyever changed the title Fix errors Fix extra-semi-stmt warnings Mar 9, 2025
Copy link
codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.49%. Comparing base (86994b1) to head (5090cf6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6771   +/-   ##
=======================================
  Coverage   56.49%   56.49%           
=======================================
  Files         509      509           
  Lines       32724    32724           
  Branches     3097     3097           
=======================================
  Hits        18487    18487           
  Misses      13379    13379           
  Partials      858      858           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@cyyever cyyever force-pushed the fix_errors branch 4 times, most recently from 103895b to ce4c095 Compare March 9, 2025 01:42
@cyyever cyyever marked this pull request as ready for review March 9, 2025 02:06
@cyyever
Copy link
Contributor Author
cyyever commented Mar 11, 2025

The test failures are unrelated.

Signed-off-by: cyy <cyyever@outlook.com>
@andife andife requested a review from justinchuby June 14, 2025 16:34
@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in PR Tracker Jun 14, 2025
@justinchuby justinchuby added this pull request to the merge queue Jun 14, 2025
@justinchuby justinchuby added the topic: better engineering Improve engineering quality of the project label Jun 14, 2025
Merged via the queue into onnx:main with commit 9bc1ae6 Jun 14, 2025
59 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in PR Tracker Jun 14, 2025
@cyyever cyyever deleted the fix_errors branch June 15, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: better engineering Improve engineering quality of the project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants
0