8000 Fix sorting in export by beckyjackson · Pull Request #654 · ontodev/robot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix sorting in export #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Fix sorting in export #654

merged 2 commits into from
Mar 18, 2020

Conversation

beckyjackson
Copy link
Contributor
@beckyjackson beckyjackson commented Mar 18, 2020
  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

Ran into a minor problem with comparing empty strings:

Comparison method violates its general contract!

Apparently there was a transitivity issue in the comparator method.

@jamesaoverton jamesaoverton merged commit 7af9921 into master Mar 18, 2020
@beckyjackson beckyjackson deleted the sort-fix branch March 18, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0