8000 Add more formats to report, including HTML by beckyjackson · Pull Request #699 · ontodev/robot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add more formats to report, including HTML #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 18, 2020
Merged

Add more formats to report, including HTML #699

merged 11 commits into from
Sep 18, 2020

Conversation

beckyjackson
Copy link
Contributor
@beckyjackson beckyjackson commented May 27, 2020 •
edited
Loading

Resolves #620
Also adds JSON and XLSX formats to report.

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • CHANGELOG.md has been updated
  • mvn site says all JavaDocs correct

Add more formats to report using the export Table object. This will allow us to add even more formats as we add them to export. Note that for JSON and YAML formats, we don't use the toJSON from the Table object because we want to group by error-level and rule name.

Any non-CSV format will print tab-separated values when using the --print option (I don't think it makes sense to print the first N violations of an HTML doc, for example...). For formats HTML, XLSX, JSON, and YAML, an --output is required. For TSV and CSV, the output is optional - if not included, all output will be printed to the console.

This also adds a --standalone option to both report and export when outputting HTML.

@beckyjackson
Copy link
Contributor Author

This could cause some conflicts with #691 - not sure what the best order to merge is.

@jamesaoverton
Copy link
Member

What's going on with Violations.java?

@beckyjackson
Copy link
Contributor Author

I changed to using OWL objects instead of just string representations of the IRIs so that we can render them with our various renderers we use for export (like the HTML renderer). Otherwise I'd have to write another method that takes a string IRI, maybe finds a label or makes a CURIE, and turns this into a link.

@beckyjackson beckyjackson mentioned this pull request Jun 6, 2020
Merged
5 tasks
@beckyjackson beckyjackson marked this pull request as draft June 29, 2020 15:02
@beckyjackson
Copy link
Contributor Author

I'd like to wait for #691 before merging this so I can work out any merge conflicts.

@beckyjackson beckyjackson marked this pull request as ready for review September 3, 2020 15:47
@beckyjackson beckyjackson mentioned this pull request Sep 15, 2020
Closed
@beckyjackson
Copy link
Contributor Author

The bug that caused the background colors to not display properly in HTML reports is fixed and this is ready to go.

@jamesaoverton jamesaoverton merged commit 56e688e into master Sep 18, 2020
@jamesaoverton jamesaoverton deleted the html-report branch June 16, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesaoverton jamesaoverton jamesaoverton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML output for report
2 participants
@beckyjackson @jamesaoverton
0