8000 Add standardized error output to `template` by beckyjackson · Pull Request #713 · ontodev/robot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add standardized error output to template #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 18, 2020
Merged

Add standardized error output to template #713

merged 7 commits into from
Aug 18, 2020

Conversation

beckyjackson
Copy link
Contributor
@beckyjackson beckyjackson commented Jul 28, 2020 •
edited
Loading

Resolves #712

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

This adds an --errors <path> option to template to write a table of all errors (as specified in #712) to the provided path (CSV or TSV).

@beckyjackson
Copy link
Contributor Author

I'd like to wait on #691 before merging this so I'm marking it as a WIP.

@beckyjackson beckyjackson marked this pull request as draft July 29, 2020 14:43
@beckyjackson beckyjackson marked this pull request as ready for review August 17, 2020 16:52
@beckyjackson
Copy link
Contributor Author
beckyjackson commented Aug 17, 2020 •
edited
Loading

The template classes (especially TemplateHelper.java) now have a ton of deprecated methods from when we changed the way it works. If we remove these, make validate will fail because of removed methods, but I'm wondering if we should consider allowing that since they've been deprecated for quite some time now? @jamesaoverton

@jamesaoverton jamesaoverton merged commit 5ff7ae4 into master Aug 18, 2020
@jamesaoverton jamesaoverton mentioned this pull request Oct 7, 2020
Closed
@jamesaoverton jamesaoverton deleted the error-tables branch June 16, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardized output for lists of problems with an input table
2 participants
@beckyjackson @jamesaoverton
0