8000 Multi annotation column by pk-mitre · Pull Request #1205 · ontodev/robot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Multi annotation column #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Multi annotation column #1205

wants to merge 3 commits into from

Conversation

pk-mitre
Copy link
Contributor

Resolves [#ISSUE, resolves #ISSUE]

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

[DESCRIPTION, mentioning relevant #ISSUE]

@jamesaoverton
Copy link
Member

The PR looks good. I'm a bit hesitant about this feature, because I don't see the benefit of using a single column over multiple columns. Can you describe your use case? Is it that your single AP column might contain many different annotation properties?

@jamesaoverton
Copy link
Member

I'm still having trouble seeing the use case for this, but I'm not opposed to it. Can you please complete the documentation for this feature in template.md?

@dlutz2
Copy link
dlutz2 commented Jan 19, 2025

I'd like to see this capability added. We use dozens of annotation properties for curation and domain specific descriptions but an individual term is likely to use only a small number (but necessarily the same ones in a batch). Putting both the property and literal into a single pipe-separated field keeps us from maintaining very wide but sparse spreadsheets and we don't have to change the template when we add new annotation properties.

@jamesaoverton
Copy link
Member

Thanks @dlutz2. Have you used or tested this PR?

@dlutz2
Copy link
dlutz2 commented Jan 23, 2025

We've been using the multi-annotation capability in production since it was proposed. Been working fine.

@jamesaoverton jamesaoverton mentioned this pull request Mar 7, 2025
Merged
5 tasks
@jamesaoverton
Copy link
Member
jamesaoverton commented Mar 7, 2025 •
edited
Loading

I made some changes and generalizations to this in #1249 Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pk-mitre @jamesaoverton @dlutz2
0