8000 Cloud onboarding proposal by ocampana-videotec · Pull Request #462 · onvif/specs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cloud onboarding proposal #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 59 commits into
base: development
Choose a base branch
from
Open

Cloud onboarding proposal #462

wants to merge 59 commits into from

Conversation

ocampana-videotec
Copy link
Contributor

I closed the previous one, moved the cloud FW upgrade proposal in its own branch and rebased everything on top of development

@ocampana-videotec
Initial commit
2715535
@ocampana-videotec
Feedback from the F2F meeting
837a54e
@ocampana-videotec
Adding the openapi specification for cloud integration
9cf3d1e
@ocampana-videotec
Backup
7e40ef6
@ocampana-videotec
Updated file
a71eb18
@ocampana-videotec
Enhancements
4c54b74
@ocampana-videotec
Correct wrong file names
171bca3
@ocampana-videotec
fix docbook accordingly
9eae4f1
@ocampana-videotec
Update following the first discussion during the F2F meeting in Krakow
097924b
@ocampana-videotec
Trying to enhance the descriptions
6ddce00
@ocampana-videotec
Testing a better look in redoc
15363cc
@ocampana-videotec
Small enhancements
8dc7dc7
@ocampana-videotec
Including Genetec's feedback
08ef1fe
@ocampana-videotec
Feedback after the discussion of June 7
fd6b1b5
@ocampana-videotec
First proposal for cloud firmware upgrade
2315f48
@ocampana-videotec
I forgot to save one file...
1e22279
@ocampana-videotec
Implement paging for FW versions retrieval
acf745a
10000
@ocampana-videotec
Including feedback from Jose
7eb6402
@ocampana-videotec
added capability and fixing a few typos
9cef116
@ocampana-videotec
Revert "added capability and fixing a few typos"
e51909a 
This reverts commit 35a3629.
@ocampana-videotec
Revert "Implement paging for FW versions retrieval"
d1b3d9b 
This reverts commit 4a69758.
@ocampana-videotec
Revert "I forgot to save one file..."
cf9932f 
This reverts commit 6b30ccc.
@ocampana-videotec
Revert "First proposal for cloud firmware upgrade"
bf604f6 
This reverts commit 90176fc.
@ocampana-videotec
Included the requirement of the xaddr claim for the share token, so t…
2bbf564 
…hat the OCS knows how to contact the PCS.
@ocampana-videotec ocampana-videotec added 24.12 enhancement New feature or request labels Sep 11, 2024
jflevesque-genetec
jflevesque-genetec reviewed Sep 12, 2024
View reviewed changes
jflevesque-genetec
jflevesque-genetec reviewed Sep 12, 2024
View reviewed changes
@kieran242
Copy link
Contributor

@ocampana-videotec @jmelancongen Are the blocking issues resolved in this PR ?

@sujithhanwha
Copy link
Contributor

@ocampana-videotec , please check these two improvement points.

Improvement Point 1:
in the device sharing completed notification, there is no way to notify failure, to handle this
have follow suggestion please check,

Suggestion 1: we can add a new path like /deviceSharingFailed
or
Suggestion 2: we could modify the deviceSharingCompleted structure like below,

deviceSharingCompleted:
      type: object
      oneOf:
        - properties:
            success:
              description: Indicates whether the operation was successful.
              type: boolean
              example: true
            shareToken:
              description: The share token, to know what device the public key is associated with.
              type: string
            devicePublicKey:
              description: The public key of the device.
              $ref: '#/components/schemas/base64DerEncodedAsn1Value'
          required:
            - success
            - shareToken
            - devicePublicKey
        - properties:
            success:
              description: Indicates whether the operation was successful.
              type: boolean
              example: false
            errorCode:
              description: A code representing the type of error.
              type: integer
            errorMessage:
              description: A human-readable message providing more details about the error.
              type: string
          required:
            - success
            - errorCode
            - errorMessage

Improvement Point 2:
Additionally securitySchemes is also not defined under components

securitySchemes:
    BearerAuth:
      type: http
      scheme: bearer
      bearerFormat: JWT

in the spec

security:
  - BearerAuth: []

@ocampana-videotec ocampana-videotec marked this pull request as ready for review June 4, 2025 08:16
ocampana-videotec
ocampana-videotec commented Jun 4, 2025
View reviewed changes
Copy link
Contributor Author
@ocampana-videotec ocampana-videotec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems ok

jflevesque-genetec
jflevesque-genetec reviewed Jun 4, 2025
View reviewed changes
doc/CloudIntegration.xml
@@ -260,7 +280,7 @@
<title>Security</title>
<section>
<title>Authentication</title>
<para>The functions defined in this document do not require authehtication, since presenting
<para>The functions defined within this document do not require authehtication, since presenting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>The functions defined within this document do not require authehtication, since presenting
<para>The functions defined within this document do not require authentication, since presenting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jflevesque-genetec jflevesque-genetec jflevesque-genetec left review comments

@sujithhanwha sujithhanwha sujithhanwha left review comments

@kieran242 kieran242 kieran242 left review comments

@tomasz-zajac tomasz-zajac tomasz-zajac left review comments

@jmelancongen jmelancongen jmelancongen left review comments

@HansBusch HansBusch Awaiting requested review from HansBusch

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
25.06 enhancement New feature or request Prototyping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3D44
7 participants
@ocampana-videotec @jflevesque-genetec @kieran242 @sujithhanwha @tomasz-zajac @jmelancongen @HansBusch
0