WebRTC updated with Extend and Capabilities #572
Conversation
|
hi @helu-milestone , I may be misunderstanding the flow, and I guess I only care about the device side: But if two sessions (by two clients) are being set up at the same time from the same device, without a sessionID in the messages, how can the device know which SDP-answer belongs to which client? |
|
@jcadev the signaling server is in charge of generating a sessionId for each connect request before forwarding them to the device, so the device will have that information in hand to respond. The diagram shows that part a bit better |
Co-authored-by: jmelancongen <115079765+jmelancongen@users.noreply.github.com>
There was a problem hiding this comment.
I reviewed whole document via the developer specs portal and it reads cleanly also I have noted you applied my suggestions from the previous PR and also @jmelancongen updates and are trying to address @jcadev updates.
I am willing to approve this.
Only 1 thing you did not update yourself to the "Annex A Revision History".
This was created based on this issue (#489) and F2F meeting discussion. Note, the communication diagram have been updated with details of what is optional parameters, please let me know what you think.
I had a PR made on a forked branch, but it was hard to review as there was no rendering. The old PR is here:
#547
I will reply to the comments from the old PR here:
@kieran242 I believe I have updated this PR with your suggestions.
@jcadev I've been through your comments and taken in your suggestions. You mentioned about adding SessionID to Answer-SDP and ExpiryTime. I'm not sure I follow you. If it is for the Client/Device to understand which session the reply is comming from, I believe that can be handled by the id of the message, as that will connect the response message to the request message. In the request message the client will know which session this is about.