10000
fix: optimistic lock condition #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug in the optimistic lock condition by updating the condition expression for DynamoDB PutItem requests to account for the non-existence of the version attribute. Key changes include:
- Updating the condition expression in put_item.go to use "attribute_not_exists(#version) or #version = :oldVersion"
- Removing the explicit creation of a new account item in tests/putitem_test.go
- Refining the error variable assignment in the test file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/putitem_test.go | Removed unnecessary account creation and refined variable assignment. |
| put_item.go | Updated the optimistic lock condition expression to account for new items. |
Comments suppressed due to low confidence (2)
put_item.go:24
- The updated optimistic lock condition now correctly handles the case when the version attribute does not exist. Please confirm that this change fully aligns with the intended behavior for new item creation.
condition := "attribute_not_exists(#version) or #version = :oldVersion"
tests/putitem_test.go:147
- Using the short variable declaration improves clarity; however, please ensure that error handling remains consistent and any potential errors from GetItem are handled appropriately.
err, _ := table.GetItem(ctx, pk, pk, &acc)
shidil
approved these changes
Jul 1, 2025
shidil
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes optimistic lock condition to consider possibility of
versionattribute being non existing.Info on how
attribute_not_existsfunction works:https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Expressions.OperatorsAndFunctions.html#Expressions.OperatorsAndFunctions.Functions
Fixes:
Bug in the optimistic lock condition where the
PutItemrequest fails with error (if attribute does not exists):Other information & screenshots: