8000 refactor: use node input instead of input def and from by leavesster · Pull Request #184 · oomol/oocana-rust · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: use node input instead of input def and from #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jun 26, 2025
Merged

refactor: use node input instead of input def and from #184

merged 33 commits into from
Jun 26, 2025

Conversation

leavesster
Copy link
Contributor
@leavesster leavesster commented Jun 23, 2025 •
edited
Loading

fix #183

Merge inputs_def inputs_def_patch from field to NodeInput struct. And add input_def.value to NodeInput struct.

#[derive(Debug, Clone)]
pub struct NodeInput {
    pub def: InputHandle,
    pub patch: Option<Vec<InputDefPatch>>,
    pub value: Option<Option<JsonValue>>,
    pub from: Option<Vec<HandleFrom>>,
}

@leavesster leavesster closed this Jun 24, 2025
@leavesster leavesster reopened this Jun 24, 2025
@leavesster leavesster closed this Jun 24, 2025
@leavesster leavesster reopened this Jun 24, 2025
@leavesster leavesster force-pushed the node-input branch 2 times, most recently from 05f7981 to 20801ff Compare June 24, 2025 10:08
@leavesster leavesster changed the title refactor: use node input instead of input and from refactor: use node input instead of input def and from Jun 24, 2025
@leavesster leavesster force-pushed the node-input branch 4 times, most recently from e453d44 to bdca198 Compare June 25, 2025 11:00
leavesster added 19 commits June 26, 2025 11:51
@leavesster
refactor: use inputs field to store input, from and value
5386413
@leavesster
refactor: merge node inputs from generate and consider value
7f2dc63
@leavesster
feat: filter value from connection
5176249
@leavesster
refactor: remove node input def usage
bc61a82
@leavesster
fix: filter value connection
e4935df
@leavesster
chore: add some warning for now currently not used field
e00dba0
@leavesster
refactor: fix issue #183
d5497f3
@leavesster
refactor
27af636
@leavesster
fix: also update slot node's inputs
eed0339
@leavesster
refactor: reduce owned type
9afce8e
@leavesster
refactor: use inputs instead of from
f68afd5
@leavesster
refactor: remove from usage
f78ffc7
@leavesster
refactor: remove no used fn
b33cc23
@leavesster
refactor: remove from field
0a2bf8b
@leavesster
refactor: remove slot node from field
11256a2
@leavesster
refactor: remove inputs_def and inputs_def patch field
2897773
@leavesster
refactor: remove inputs def and inputs def patch
82131cb
@leavesster
refactor: generate inputs def and patch from input
3ffa575
@leavesster
refactor: remove inputs def
6144c92
@leavesster leavesster merged commit 7af1d6d into main Jun 26, 2025
12 checks passed
@leavesster leavesster deleted the node-input branch June 26, 2025 03:57
@oomol-bot oomol-bot mentioned this pull request Jun 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: remove input def value usage
1 participant
@leavesster
0