8000 test: improve flow test by leavesster · Pull Request #203 · oomol/oocana-rust · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: improve flow test #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 2, 2025
Merged

test: improve flow test #203

merged 6 commits into from
Jul 2, 2025

Conversation

leavesster
Copy link
Contributor
  • refactor: use regular directory struct
  • refactor: rename argument name

@leavesster leavesster requested a review from Copilot July 1, 2025 09:32
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the test infrastructure to adopt a regular directory structure and improve naming clarity.

  • Renamed the helper function from dirname() to test_directory() in test files.
  • Updated the YAML file to use a new directory structure for task paths.
  • Renamed the argument in find_flow() from flow_name to flow_path to improve clarity.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
manifest_reader/tests/flow_manifest_reader_test.rs Renamed helper function for improved clarity in test directory lookup.
manifest_reader/tests/flow.oo.yaml Updated task path to match new directory structure.
manifest_reader/src/path_finder/flow.rs Renamed function parameter and updated error message for consistency.

@leavesster leavesster changed the title refactor: improve test test: improve flow test Jul 2, 2025
@leavesster leavesster merged commit e4ec7bb into main Jul 2, 2025
13 checks passed
@leavesster leavesster deleted the refactor branch July 2, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0