Open MPCORB input file as read only #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Siltala: There is already a subroutine that does exactly what you want: setActionRead(this). To use it, simply change the code from call new(yourfile) to call new(yourfile) So no need to add functionality to File_class. |
|
Oh, thank you, I missed that. I will change the PR accordingly |
|
Simplified this a lot to a one liner - as per Mikael's comment above almost everything was actually being opened as read only anymore. The only exception was the MPCORB file in the mpcorb task (and I confirmed on our end that is the exact task we had the problem with). Now this PR just has a single line added to open that as read only too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR simplified a lot to only open MPCORB as read only - this was already the case for other input files.
This PR changes the NEW subroutine in File.f90 to accept an optional argument for specifying whether to open a file as read only or in read+write mode. If it is not specified, the default is the same as the current behavior (read+write).The second commit changes oorb.f90 to open input observation files, orbit files, and the configuration file as read only. I'm pretty sure that we don't write to input files anywhere (and output files are not changed) and from my testing so far everything still works.This is useful for certain setups where the input data are in a folder oorb doesn't have write access to.