8000 chore(docker): Move root docker builds into `docker` dir by clabby · Pull Request #1878 · op-rs/kona · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(docker): Move root docker builds into docker dir #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

chore(docker): Move root docker builds into docker dir #1878

merged 1 commit into from
May 27, 2025

Conversation

clabby
Copy link
Collaborator
@clabby clabby commented May 27, 2025

Overview

Removes the build-node, build-node-with-tag, and build-supervisor-with-tag recipes in favor of docker/apps/justfile's recipes.

closes #1596

@clabby clabby self-assigned this May 27, 2025
@clabby clabby added K-chore Kind: chore A-docker Area: Dockerfiles labels May 27, 2025
@clabby clabby mentioned this pull request May 27, 2025
Merged
@clabby
Copy link
Collaborator Author
clabby commented May 27, 2025

📚 PR Stack

This comment was auto-generated

@codecov Codecov
Copy link
codecov bot commented May 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.7%. Comparing base (c843899) to head (c9dfa8c).
Report is 1 commits behind head on cl/docker-local-builds.

✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clabby clabby merged commit 5f16f04 into cl/docker-local-builds May 27, 2025
21 of 22 checks passed
@clabby clabby deleted the cl/justfile-docker-clean branch May 27, 2025 16:20
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking May 27, 2025
clabby added a commit that referenced this pull request May 27, 2025
@clabby
chore(docker): Move root docker builds into docker dir (#1878)
64ef9bb 
## Overview

Removes the `build-node`, `build-node-with-tag`, and
`build-supervisor-with-tag` recipes in favor of `docker/apps/justfile`'s
recipes.

closes #1596
clabby added a commit that referenced this pull request May 27, 2025
@clabby
chore(docker): Move root docker builds into docker dir (#1878)
800e09f 
## Overview

Removes the `build-node`, `build-node-with-tag`, and
`build-supervisor-with-tag` recipes in favor of `docker/apps/justfile`'s
recipes.

closes #1596
clabby added a commit that referenced this pull request May 27, 2025
@clabby
chore(docker): Move root docker builds into docker dir (#1878)
8fad0fc 
## Overview

Removes the `build-node`, `build-node-with-tag`, and
`build-supervisor-with-tag` recipes in favor of `docker/apps/justfile`'s
recipes.

closes #1596
clabby added a commit that referenced this pull request May 27, 2025
@clabby
chore(docker): Move root docker builds into docker dir (#1878)
415bba5 
## Overview

Removes the `build-node`, `build-node-with-tag`, and
`build-supervisor-with-tag` recipes in favor of `docker/apps/justfile`'s
recipes.

closes #1596
clabby added a commit that referenced this pull request May 27, 2025
@clabby
feat(docker): Local builds + Cleanup
fdb3bb3 
chore(docker): Move root docker builds into `docker` dir (#1878)

## Overview

Removes the `build-node`, `build-node-with-tag`, and
`build-supervisor-with-tag` recipes in favor of `docker/apps/justfile`'s
recipes.

closes #1596
github-merge-queue bot pushed a commit that referenced this pull request May 28, 2025
@clabby
feat(docker): Local builds + Cleanup (#1877)
acc5e14 
## Overview

Adds support for building images for apps in the local repo with the
generic docker application image. Also cleans up the documentation, and
adds a `justfile` script for easily building local images.

~~This PR does not yet replace recipes such as `build-node`,
`build-node-with-tag`, or `build-supervisor-with-tag`. That transition
will be done in a follow-up, but must be merged into this before `main`
since this is a breaking change to the dockerfile.~~ done w/ #1878

closes #1813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theochap theochap theochap approved these changes

@refcell refcell Awaiting requested review from refcell

@emhane emhane Awaiting requested review from emhane

Assignees

@clabby clabby

Labels
A-docker Area: Dockerfiles K-chore Kind: chore
Projects
Project Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @theochap
0