8000 test(supervisor): Comment out kona-supervisor in kurtosis network params by emhane · Pull Request #1873 · op-rs/kona · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test(supervisor): Comment out kona-supervisor in kurtosis network params #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

test(supervisor): Comment out kona-supervisor in kurtosis network params #1873

merged 1 commit into from
May 27, 2025

Conversation

emhane
Copy link
Member
@emhane emhane commented May 27, 2025

Unblocks #1716. Allows writing supervisor e2e tests in kona and only running against op-supervisor until kona-supervisor support is integrated into optimism-package.

Ref
https://github.com/op-rs/kona/tree/main/tests/supervisor
ethpandaops/optimism-package#281

@emhane emhane added A-ci Area: CI M-tests Meta: Testing related W-supervisor Workstream: supervisor labels May 27, 2025
@emhane emhane added the K-kurtosis Kind: related to kurtosis integration label May 27, 2025
Copilot
Copilot AI reviewed May 27, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily comments out the supervisor-b configuration in the simple-supervisor YAML to unblock e2e tests by using op-supervisor until kona-supervisor support is available.

  • Commented out the supervisor-b block in the YAML file
  • Added a temporary note with a reference to the related GitHub issue

@codecov Codecov
Copy link
codecov bot commented May 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.6%. Comparing base (fa40686) to head (a358080).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emhane emhane merged commit a7e83cf into main May 27, 2025
21 of 22 checks passed
@emhane emhane deleted the emhane/supervisor-kurtosis-network-params branch May 27, 2025 14:21
@emhane emhane mentioned this pull request May 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@dhyaniarun1993 dhyaniarun1993 dhyaniarun1993 approved these changes

@itschaindev itschaindev Awaiting requested review from itschaindev

@sadiq1971 sadiq1971 Awaiting requested review from sadiq1971

@clabby clabby Awaiting requested review from clabby clabby is a code owner

@refcell refcell Awaiting requested review from refcell refcell is a code owner

@theochap theochap Awaiting requested review from theochap theochap is a code owner

Assignees
No one assigned
Labels
A-ci Area: CI K-kurtosis Kind: related to kurtosis integration M-tests Meta: Testing related W-supervisor Workstream: supervisor
Projects
Project Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @dhyaniarun1993
0