chore(supervisor): error logs consistency #1889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emhane
approved these changes
May 28, 2025
Comment on lines
22
to
24
| #[display( | ||
| "BlockRef {{ number: {number}, hash: {hash}, parent_hash: {parent_hash}, timestamp: {timestamp} }}" | ||
| )] |
There was a problem hiding this comment.
Suggested change
| #[display( | |
| "BlockRef {{ number: {number}, hash: {hash}, parent_hash: {parent_hash}, timestamp: {timestamp} }}" | |
| )] | |
| #[display( | |
| "number: {number}, hash: {hash}, parent_hash: {parent_hash}, timestamp: {timestamp}" | |
| )] |
this looks like the debug format, the suggested format is expected for display, see docs https://doc.rust-lang.org/rust-by-example/hello/print/print_display.html
| })?; | ||
|
|
||
| let block = block_option.ok_or_else(|| { | ||
| warn!(target: "supervisor_storage", block_number, "Block not found"); | ||
| StorageError::EntryNotFound(format!("Block {} not found", block_number)) | ||
| StorageError::EntryNotFound(format!("block {} not found", block_number)) |
There was a problem hiding this comment.
Suggested change
| StorageError::EntryNotFound(format!("block {} not found", block_number)) | |
| StorageError::EntryNotFound(format!("block {block_number} not found")) |
Comment on lines
164
to
165
| "log not found at block {} index {}", | ||
| block_number, log.index |
There was a problem hiding this comment.
Suggested change
| "log not found at block {} index {}", | |
| block_number, log.index | |
| "log not found at block {block_number} index {}", | |
| log.index |
Comment on lines
+48
to
+49
| /// This method is append only and does not overwrite existing pairs. | ||
| /// Ensures that the latest stored pair is the parent of the incoming pair before saving. |
itschaindev
a
8000
pproved these changes
May 28, 2025
theochap
pushed a commit
that referenced
this pull request
May 29, 2025
theochap
pushed a commit
that referenced
this pull request
May 29, 2025
theochap
pushed a commit
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.