8000 chore(msrv): Bump rust to version 1.87 by emhane · Pull Request #1919 · op-rs/kona · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(msrv): Bump rust to version 1.87 #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

emhane
Copy link
Member
@emhane emhane commented May 30, 2025

Closes #1845

@Copilot Copilot AI review requested due to automatic review settings May 30, 2025 08:50
@emhane emhane added the F-deps Flag: Updates dependencies label May 30, 2025
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the minimum supported Rust version and extends imports to include a recoverable signer type for transaction processing

  • Bump the rust-version field in Cargo.toml from 1.85 to 1.87
  • Add SignerRecoverable trait import in calldata and blobs source modules

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
crates/protocol/derive/src/sources/calldata.rs Added transaction::SignerRecoverable import
crates/protocol/derive/src/sources/blobs.rs Extended alloy_consensus import to include SignerRecoverable
Cargo.toml Updated rust-version to 1.87

Copy link
codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.8%. Comparing base (4e2b929) to head (762597e).
Report is 45 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/node/p2p/src/peers/nodes.rs 0.0% 2 Missing ⚠️
crates/node/p2p/src/peers/store.rs 0.0% 2 Missing ⚠️
crates/node/p2p/src/net/driver.rs 0.0% 1 Missing ⚠️
crates/node/rpc/src/launcher.rs 0.0% 1 Missing ⚠️
crates/proof/mpt/src/list_walker.rs 0.0% 1 Missing ⚠️
crates/protocol/protocol/src/batch/tx.rs 0.0% 1 Missing ⚠️
crates/protocol/registry/src/chain_list.rs 50.0% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emhane emhane force-pushed the emhane/bump-rust-version branch from 3c28e84 to 8b52843 Compare May 30, 2025 11:04
@emhane emhane force-pushed the emhane/bump-rust-version branch from 750bd86 to 35086dc Compare May 30, 2025 11:43
@emhane emhane force-pushed the emhane/bump-rust-version branch from 35086dc to 05eebb6 Compare May 30, 2025 11:44
@clabby
Copy link
Collaborator
clabby commented Jun 3, 2025

pref #1945 - performs the minimum bump to allow us to update the reth deps.

@clabby
Copy link
Collaborator
clabby commented Jun 4, 2025

Closing for now with the update to 1.86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-deps Flag: Updates dependencies
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bump rust version
2 participants
0