8000 fix(node/p2p): Gossipsub connection metric keys by clabby · Pull Request #1947 · op-rs/kona · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(node/p2p): Gossipsub connection metric keys #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

fix(node/p2p): Gossipsub connection metric keys #1947

merged 1 commit into from
Jun 3, 2025

Conversation

clabby
Copy link
Collaborator
@clabby clabby commented Jun 3, 2025

Overview

Fixes the kona_node_gossipsub_connection metrics to have proper type labels, allowing for filtering by type in the grafana visualizations.

@clabby clabby self-assigned this Jun 3, 2025
@clabby clabby requested review from refcell and emhane as code owners June 3, 2025 02:16
@clabby clabby added the K-fix Kind: fix label Jun 3, 2025
@clabby clabby requested a review from theochap as a code owner June 3, 2025 02:16
@clabby clabby added M-metrics Meta: metric related A-p2p Area: p2p W-node Workstream: kona-node labels Jun 3, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.7%. Comparing base (07709ae) to head (0a4a3fd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/node/p2p/src/gossip/driver.rs 0.0% 12 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from cl/bump-msrv-1.86 to main June 3, 2025 02:31
theochap
theochap approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member
@theochap theochap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: this pr also updates the rust version. Is that intended?
Otherwise looks great

@github-project-automation github-project-automation bot moved this to In Review in Project Tracking Jun 3, 2025
@clabby
Copy link
Collaborator Author
clabby commented Jun 3, 2025

Just checking: this pr also updates the rust version. Is that intended? Otherwise looks great

Ah this is from #1945 - rebasing

@clabby clabby force-pushed the cl/gossipsub-connection-metric-keys branch from ee0d2a1 to 0a4a3fd Compare June 3, 2025 02:53
@clabby clabby enabled auto-merge June 3, 2025 02:54
@clabby clabby added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit cd3c689 Jun 3, 2025
25 of 27 checks passed
@clabby clabby deleted the cl/gossipsub-connection-metric-keys branch June 3, 2025 11:40
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theochap theochap theochap approved these changes

@refcell refcell Awaiting requested review from refcell refcell is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@clabby clabby

Labels
A-p2p Area: p2p K-fix Kind: fix M-metrics Meta: metric related W-node Workstream: kona-node
Projects
Project Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @theochap
0