feat(node/engine): Add info log for safe head promotion
#1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds structured timing logs upon successful safe head promotion in ConsolidateTask.
- Introduce
Instanttimers to measure total, block-fetch, and fork-choice-update durations - Emit an
info!log with block hash, number, and timing details on successful consolidation - Change fallback log for build task from
trace!todebug!
Comments suppressed due to low confidence (1)
crates/node/engine/src/task_queue/tasks/consolidate/task.rs:120
- [nitpick] There are no tests verifying that this
info!log is emitted with the correct fields after successful consolidation. Consider adding or updating integration tests that assert the structured log includeshash,number, and all timing fields.
info!(
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emhane
approved these changes
Jun 3, 2025
refcell
approved these changes
Jun 3, 2025
This already has a metric :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds an
infolog for when theConsolidateTasksuccessfully promotes the safe head of the chain.