[wip/1.0] Remove "name" as required parameter #70
Comments
|
It should still be required as that's how a consumer can generally expect a user name reliably from a provider. If there's no standard "username" per se, the strategy author should still "make one up" in a predictable manner, eg. by using firstname (if it's available), or worst of it all, just a repeat of uid. |
|
I'm not sure I agree. Take Steam for example, which uses OpenID and provides no attributes (see here). The only available information here would be the identity or claimed_id, "http://steamcommunity.com/openid/id/76561198109020728" is not very useful as a "name" IMHO. Why should there always be a name? What about email and first/last name, should that be required too? |
|
I'm not all too familiar with Steam, but there's |
|
It requires an API key ... I have an API key, but I'm controlling it's use because it's limited to 100,000 requests per day. It seems like a lot, but it's used to access match history of players (1 match at a time), so it won't last long. I would prefer to control when this player data is retrieved, because I need it for users that log in via other strategies as well, for example Google and Twitter. Also, it would mean writing a custom strategy for Steam, instead of simply aliasing the OpenID strategy. |
|
@ceeram agrees with you, so I wrote a simple strategy for Steam @ https://github.com/glen-84/opauth-steam |
|
Would be nice if it followed same folder and file structure as other 2013/10/19 glen-84 notifications@github.com
|
|
Why can't others use it like this? It has psr-0 autoloading. The way I did it follows many other libraries ("src" is sometimes replaced with "lib" or "library"), and allows you to have other folders such as "tests" and "docs" alongside it. BTW, I e-mailed Mewp to ask him if he could submit LightOpenID to packagist. If he doesn't do so within the next few days I'll probably just submit it myself. Until then, you have to add the Git repository to your root project and also use a stability flag ("lightopenid/lightopenid": "@dev"). |
|
lightopenid has been added to packagist, there have been some changes to 1.0 strategies in the meantime. I can help update the steam strategy, but i need your help for further testing it. |
|
I have a case when facebook app return response with I think that validation can be set as optional. Then we can change way we want to validate response. |
Opauth, as its name suggests, is about authentication, so the only required information from the provider should be some form of identifier.
As not all providers will supply a name (f.e. the Steam OpenID provider), "name" should not be a required parameter.
Please remove this requirement in order to support such providers.
https://github.com/opauth/opauth/blob/wip/1.0/lib/Opauth/Response.php#L149
The text was updated successfully, but these errors were encountered: