Fixed a bug with navbar displaying appendixes subroutes #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh man, you are my hero. This has been bugging me for years and I never spotted it! |
eepMoody
approved these changes
Jun 20, 2023
eepMoody
added a commit
that referenced
this pull request
Jul 1, 2023
* fix: #377 blockquote styles (#381) * Nuxt 3 with Pinia (#385) * Migrate to Nuxt 3 with pinia * Create package-lock.json * Temporary side-not style fix * Small homepage change to detect deployment --------- Co-authored-by: Ean Moody <moody.designer@gmail.com> * Update package-lock, see if this resolves errors * adjust config to test deployment * set nitro to digital-ocean preset * set nitro to digital-ocean preset for real this time * adjust vue alias based on client vs. server * remove extra value in monster axios call * Fix linting issues, enforce linting in pre-commit (#386) * Fix linting issues, enforce linting in pre-commit * add vue eslint * eslint recommended, we can be strict. * First --fix pass, 73 more problems * Ignore vue/multi-word-component-names --------- Co-authored-by: Ean Moody <moody.designer@gmail.com> * fix all lint errors - apply prettier to affected pages (#388) * GitHub Actions CI / PR validation * Prettify all the things forever (#389) * add prettier formatting to pre-commit hooks * test * add pretty-quick for quick file formatting * test * test * prettify all the things * tweak ci actions to remove duplicate warnings (probably) * code review fix * fix lint warnings * stop eslint and prettier from fighting * add google analytics tracking for new GA4 tags (#390) * Update README.md (#394) * Update README.md * Update README.md * Accessibility Improvements (#396) * Add language attribute * Fix lists * Add alt texts * Accessibility improvements for the monster list, spell list and magic item list pages (#398) * A11y improvement for spells table * A11y improvements for item and monster lists * Change monster list currentSortProperty to match current behaviour * Show one big list when there is a filter. * Change tag color to meet contrast requirements * Extract SortableTableHeader component and add arrow icons * Add gray color variable * Adjust placeholder color * Always use h1 as page title * Adjust tag color * Correct url for search API request, avoiding 301 (#400) * Feature/tailwind (#401) * Correct url for search API request, avoiding 301 * Initial setup of Tailwind * Re-added husky * Feature/tailwind colors (#402) * colors and search page * link colors and search behavior * quick fix on sidebar colors (#403) * Fixed a bug with navbar displaying appendixes subroutes (#406) * Bump vite from 4.3.8 to 4.3.9 (#399) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.8 to 4.3.9. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.3.9/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add source selection (#404) * search loading messages and icon * create random color based on title of source * add sources to magic items, monsters, races, and spells * cleanup source tag display, add to search * prettier * Add source selection to store * implement global source settings * refactor API calls and simplify * update tables to use new call functions and fields * add persistent source selection & store locally * eslint fixes * styling cleanup * PR cleanup - unnecessary inits and loads - visual bugs - type size * code review fixes * get API calls running cleaner and more efficient * handle attempts to load during init * update modal with new slots * fix initial setting of sources * hotfix: filter on magic items list * hotfix: fields should not default to null * hotfix: prefetch on lists --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Peter <peter.binkowski@gmail.com> Co-authored-by: Matthias Nötzli <91967281+matthias-noetzli@users.noreply.github.com> Co-authored-by: David Prothero <david@prothero.com> Co-authored-by: Davey Faherty <daveyfaherty@gmail.com> Co-authored-by: calum <47755775+calumbell@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for a UI bug in the navbar.
When viewing the following sub-routes, none of which are in the Appendixes section, the ul containing the Appendixes sub-routes (which should be hidden) is shown in addition to the Characters sub-routes
I had a look at the template and found an odd looking OR in the v-show param of the Appendixes ul that didn't really make sense. It checking whether any of the sub-routes against those from the Characters section. After deleting the OR clause the problem appears to be fixed, and all of the other sub-routes ul's appear to be working as intended