8000 bmx7: transfer package from routing by aparcar · Pull Request #9406 · openwrt/packages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bmx7: transfer package from routing #9406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bmx7: transfer package from routing #9406

wants to merge 1 commit into from

Conversation

aparcar
Copy link
Member
@aparcar aparcar commented Jul 5, 2019

Maintainer: @axn
Compile tested: ath79/generic
Run tested: -

Description:

Also updating the Makefile to the the new format used in packages.git.
Future releases should use a tag instead of a commit hash.

Signed-off-by: Paul Spooren mail@aparcar.org

neheb
neheb reviewed Jul 5, 2019
View reviewed changes
BKPepe
BKPepe reviewed Jul 6, 2019
View reviewed changes
@aparcar aparcar force-pushed the bmx7 branch 2 times, most recently from ed6e214 to 586ea55 Compare July 7, 2019 12:11
@aparcar
Copy link
Member Author
aparcar commented Jul 7, 2019

Updated bmx7 to 7.1.0 instead of using the commit hash.

BKPepe
BKPepe reviewed Jul 7, 2019
View reviewed changes
BKPepe
BKPepe reviewed Jul 7, 2019
View reviewed changes
@aparcar
Copy link
Member Author
aparcar commented Jul 7, 2019

Updated, thanks!

diizzyy
diizzyy reviewed Jul 8, 2019
View reviewed changes
net/bmx7/files/etc/init.d/bmx7
@@ -0,0 +1,28 @@
#!/bin/sh /etc/rc.common
START=91
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this is 91 instead of 99?

diizzyy
diizzyy reviewed Jul 8, 2019
View reviewed changes
net/bmx7/Makefile
define Package/bmx7-uci-config
$(call Package/bmx7/Default)
DEPENDS:=bmx7 +libuci
TITLE:=configuration plugin based on uci (recommended!)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove (recommended!) and capitalize titles

diizzyy
8000 diizzyy reviewed Jul 8, 2019
View reviewed changes
diizzyy
diizzyy reviewed Jul 8, 2019
View reviewed changes
@diizzyy
Copy link
Contributor
diizzyy commented Jul 8, 2019

Several FLAGS are (incorrectly) passed multiple times and hardset, this needs to be fixed (preferably upstream if possible).

Sample:
mips-openwrt-linux-musl-gcc -pedantic -W -Wall -Wstrict-prototypes -Wno-unused-parameter -Os -g3 -std=gnu99 -DGIT_REV=\"\" -DAVL_5XLINKED -DDEBUG_MALLOC -DCORE_LIMIT=20000 -pedantic -W -Wall -Wstrict-prototypes -Wno-unused-parameter -Os -g3 -std=gnu99 -DGIT_REV=\"\" -DAVL_5XLINKED -DDEBUG_MALLOC -DCORE_LIMIT=20000 -Os -pipe -mno-branch-likely -mips32r2 -mtune=24kc -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable -Wno-error=unused-result -msoft-float -mips16 -minterlink-mips16 -iremap/home/build/build_dir/build_dir/target-mips_24kc_musl/bmx7-7.1.0:bmx7-7.1.0 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -fpic -I. -I/home/build/build_dir/staging_dir/target-mips_24kc_musl/usr/include -DCRYPTLIB=MBEDTLS_2_8_0 -DCORE_LIMIT=20000 -DTRAFFIC_DUMP -DNO_TRACE_FUNCTION_CALLS -DBMX7_LIB_IWINFO -c node.c -o node.o

Examples:
https://github.com/bmx-routing/bmx7/blob/master/Common.mk#L3
https://github.com/bmx-routing/bmx7/blob/master/Common.mk#L34
https://github.com/bmx-routing/bmx7/blob/master/Common.mk#L65
https://github.com/bmx-routing/bmx7/blob/master/lib/bmx7_evil/Makefile#L2

Since encryption is enforced you might want to disable MIPS16 instructions

@diizzyy
Copy link
Contributor
diizzyy commented Jul 29, 2019

@aparcar
Ping

@aparcar
Copy link
Member Author
aparcar commented Jul 30, 2019

@axn please look at the TARGET_CFLAGS and MAKE_ARGS issue, I can't tell what you are doing there.

@aparcar aparcar force-pushed the bmx7 branch 2 times, most recently from 8a781c8 to 46922bd Compare August 27, 2019 07:58
neheb
neheb reviewed Aug 30, 2019
View reviewed changes
@aparcar aparcar force-pushed the bmx7 branch 2 times, most recently from c817f11 to 72ec635 Compare September 3, 2019 23:24
@aparcar
bmx7: transfer package from routing
c2ff99d 
Also updating the Makefile to the the new format used in packages.git.
Future releases should use a tag instead of a commit hash.

Signed-off-by: Paul Spooren <mail@aparcar.org>
@adschm adschm mentioned this pull request Nov 4, 2019
Open
@neheb
Copy link
Contributor
neheb commented Nov 10, 2019

Please check @diizzyy comments

@aparcar
Copy link
Member Author
aparcar commented Nov 11, 2019

I can't solve the flag issue as I'm not familiar enough in C nor bmx7, closing this for now.

@aparcar aparcar closed this Nov 11, 2019
@BKPepe
Copy link
Member
BKPepe commented Mar 4, 2023

There are missing references to the routing repository, where the package was updated, and the Makefile was refactored a little bit by the OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neheb neheb neheb left review comments

@BKPepe BKPepe BKPepe left review comments

@diizzyy diizzyy diizzyy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aparcar @diizzyy @neheb @BKPepe
0