beep: change git repository includes fixes for CVE fixes #18697
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2018-1000532 Changed Git repository, which is used for Fedora packaging johnath/beep#11 (comment) Fixed CVEs: CVE-2018-0492 - https://nvd.nist.gov/vuln/detail/CVE-2018-0492 CVE-2018-1000532 - https://nvd.nist.gov/vuln/detail/CVE-2018-1000532 Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
|
CI error: May need to patch out |
|
Yes, it seems like it. I wonder why I didn't experience it on OpenWrt 21.02.x series, but during the night, I prepared env for master builds and I will fix this ASAP. |
|
Perhaps your build environment has |
|
|
There was no error for you because upstream also has |
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
|
My bad. I could not force push the current branch as it was created in this repository and not in my forked repository. :-( |
|
Hello,
Yes, it seems like it. I wonder why I didn't experience it on OpenWrt
21.02.x series, but during the night, I prepared env for master builds and
I will fix this ASAP.
Dne út 7. 6. 2022 8:57 uživatel Jeffery To ***@***.***>
napsal:
… CI error:
arm-openwrt-linux-muslgnueabi-gcc -MT beep-log.o -MMD -MP -MF .deps/beep-log.o.dep -DPACKAGE_TARNAME='"beep"' -DPACKAGE_VERSION='"1.4.12"' -D_GNU_SOURCE -D_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS -O2 -g -std=gnu99 -pedantic -Wall -Wextra -Werror -Wno-padded -Wno-format-nonliteral -Os -pipe -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable -Wno-error=unused-result -mfloat-abi=hard -ffile-prefix-map=/home/build/openwrt/build_dir/target-arm_cortex-a9+vfpv3-d16_musl_eabi/beep-1.4.12=beep-1.4.12 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -o beep-log.o -c beep-log.c
<command-line>: error: "_FORTIFY_SOURCE" redefined [-Werror]
<command-line>: note: this is the location of the previous definition
cc1: all warnings being treated as errors
make[3]: *** [GNUmakefile:277: beep-log.o] Error 1
make[3]: Leaving directory '/home/build/openwrt/build_dir/target-arm_cortex-a9+vfpv3-d16_musl_eabi/beep-1.4.12'
make[2]: *** [Makefile:46: /home/build/openwrt/build_dir/target-arm_cortex-a9+vfpv3-d16_musl_eabi/beep-1.4.12/.built] Error 2
make[2]: Leaving directory '/feed/utils/beep'
time: package/feeds/packages_ci/beep/compile#1.04#0.25#1.29
ERROR: package/feeds/packages_ci/beep failed to build.
make[1]: Leaving directory '/home/build/openwrt'
make[1]: *** [package/Makefile:116: package/feeds/packages_ci/beep/compile] Error 1
make: *** [/home/build/openwrt/include/toplevel.mk:223: package/beep/compile] Error 2
May need to patch out -Werror (or remove one of the -D_FORTIFY_SOURCE
definitions).
—
Reply to this email directly, view it on GitHub
<#18697 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7IDVHUYRQTYDVP6ZMVU7DVN3XHNANCNFSM5YAUFV6Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: n/a
Compile tested: OpenWrt 21.02.03, Turris Omnia, mvebu/cortex-a9
Run tested: N/A
Description:
My commit was sitting for some time in my stash and I did not have time to finish it. Let's solve it once for all.
Changed Git repository, which is used for Fedora packaging
johnath/beep#11 (comment)
Fixed CVEs:
CVE-2018-0492 - https://nvd.nist.gov/vuln/detail/CVE-2018-0492
CVE-2018-1000532 - https://nvd.nist.gov/vuln/detail/CVE-2018-1000532
cc: @zpc0 who were findling around this package