haproxy: Add nossl variant #342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please verify your patch. In my case haproxy is not building anymore. |
0e43b4e to
5762dca
Compare
|
Updated, it was a stupid typo. |
|
Indeed IIRC you need to set PKG_BUILD_DIR. See line 21 as example: https://dev.openwrt.org/browser/trunk/package/network/services/dnsmasq/Makefile#L21 |
|
set PKG_BUILD_DIR. is not all. you need to adjust variables in a way dnsmasq do it. |
heil
pushed a commit
that referenced
this pull request
Sep 23, 2014
According to Issue #342 here is a proposal to add a nossl variant to that builts haproxy without ssl Add pending patch from upstream - [PATCH 14/14] MEDIUM: systemd-wrapper: support multiple executable Signed-off-by: Thomas Heil <heil@terminal-consulting.de>
|
see commit 2e071ae |
|
@heil there might be typo in 2e071ae#diff-9d0464f34d4ba9a1cb94b46fbb0f03ceR79 |
|
haproxy uses crypt for a http basic auth. the nossl variant still have support for crypt. The ADDLIB addon is to ensure that the haproxy variant uses the same make options than before. Its not a Typo. |
|
I was just wondering because you changed it from -lcrypto in the diff to -lcrypt which doesn't seem to make sense to me at a first glance. |
haproxy can be built without the huge libopenssl dependency to use it as a simple http load balancer. This patch adds a haproxy-nossl variant to the Makefile, which builds it with the USE_OPENSSL flag disabled. The -lcrypto flag is also removed since it is handled by the haproxy Makefile based on the USE_OPENSSL flag. Signed-off-by: Vikraman Choudhury <vikraman@gentoo.org>
5762dca to
3346049
Compare
|
oh you are right. so i will remove the complete ADDLIB stuff. |
|
Hi, I was updating the patch, but I noticed it is already pushed. The -lcrypto is not actually required since it is handled in the haproxy Makefile. |
|
I can confirm that the current version of my patch works correctly. |
Ive changed your patch a little bitifeq ($(BUILD_VARIANT),ssl) endifdid the trick like it was done in the Makefile for dnsmasq |
|
@vikraman: are you okay with the current status? |
|
Yes, this is working fine, thanks. |
QuintinHill
added a commit
to QuintinHill/openwrt-packages
that referenced
this pull request
Mar 20, 2025
9cafbb6 fix: don't limit python upper bound (openwrt#424) 7e4cab6 fix: upgrade to ruff 0.1.0 and fix violations (openwrt#422) b7c4a31 fix: multiple calls on the root logger instead of module logger (openwrt#421) c433dab fix: ensure void methods that can raise exceptions are marked (openwrt#417) f64eb58 fix: correct size of uint32 with cython (openwrt#415) 4fcdbed fix: ensure proxy object tasks do not get garbage collected prematurely (openwrt#409) 5068e41 feat: improve performance of signature lookups (openwrt#412) 4887160 feat: improve performance of checking SignatureType tokens (openwrt#410) 0adab93 fix: correctly handle big endian data (openwrt#405) bfd48a3 feat: add support for finding message handlers when interface is None (openwrt#403) 996659e feat: refactor service bus handler lookup to avoid linear searches (openwrt#400) 6531b93 fix: reduce size of wheels (openwrt#399) a4c2743 feat: reduce size of wheels (openwrt#398) e4f37ee feat: resync generic D-Bus errors (openwrt#393) 829e0fc feat: build macos arm wheels (openwrt#387) d7213be feat: speed up marshalling messages (openwrt#383) 89026e3 feat: speed up bytearray creation in unmarshaller (openwrt#382) c21a2ac fix: docs build (openwrt#381) 586dc23 fix: attempting to unmarshall some arrays twice (openwrt#380) 18132b9 fix: wheel builds on aarch64 (openwrt#367) bdf08d2 feat: migrate to using native arm runners for wheel builds (openwrt#366) 5b61869 feat(introspect): implement annotations (openwrt#359) f58f1a6 fix: void validate arguments/properties name (openwrt#358) d376bb1 feat: improve performance of unmarshalling variants (openwrt#354) e1aaf0a feat: improve performance of marshalling message headers (openwrt#356) ebdf07e fix: revert avoid building wheels if a release is not made (openwrt#357) b1e6551 feat: speed up marshalling messages (openwrt#352) b162494 feat: speed up constructing messages from the unmarshaller (openwrt#344) 4116261 fix: race in test_tcp_connection_with_forwarding (openwrt#350) 5825758 feat: speed up unmarshalling headers (openwrt#347) a249777 fix: disable wheel builds for old python versions (openwrt#346) 1c20dcc fix: ensure exceptions are logged when no reply is expected (openwrt#342) 9c73022 fix: exclude .c files from being shipped (openwrt#331) 0f04a79 fix: remove deprecated no_type_check_decorator (openwrt#316) 2dabf2d fix: ensure build uses cython3 (openwrt#311) 1b7d28c fix: add missing cython version pin to the build system (openwrt#310) 42f1d4a feat: use dbus-run-session to drop X11 dependency (openwrt#299) 45c0e74 feat: python 3.13 support (openwrt#291) c44eb2c fix: wheel build exclude for pp37 (openwrt#285) d0ac990 feat: build wheels for aarch64 to allow use in embedded systems (openwrt#283) be68a79 fix: clear exception flag on disconnect future if its also sent to handlers (openwrt#281) 7da5d44 fix: introspection bogus child paths (openwrt#280) Signed-off-by: Quintin Hill <stuff@quintin.me.uk>
QuintinHill
added a commit
to QuintinHill/openwrt-packages
that referenced
this pull request
Apr 8, 2025
19df266 feat: use trusted publishing to upload wheels (openwrt#445) e0aeeac feat: improve unmarshall performance for SignatureType (openwrt#436) 958115f feat: simplify code to unmarshall arrays (openwrt#435) 888a3c3 feat: improve performance of unmarshalling boolean Variants (openwrt#431) 3b4bac5 feat: improve unmarshaller performance for byte strings (openwrt#430) 9cafbb6 fix: don't limit python upper bound (openwrt#424) 7e4cab6 fix: upgrade to ruff 0.1.0 and fix violations (openwrt#422) b7c4a31 fix: multiple calls on the root logger instead of module logger (openwrt#421) c433dab fix: ensure void methods that can raise exceptions are marked (openwrt#417) f64eb58 fix: correct size of uint32 with cython (openwrt#415) 4fcdbed fix: ensure proxy object tasks do not get garbage collected prematurely (openwrt#409) 5068e41 feat: improve performance of signature lookups (openwrt#412) 4887160 feat: improve performance of checking SignatureType tokens (openwrt#410) 0adab93 fix: correctly handle big endian data (openwrt#405) bfd48a3 feat: add support for finding message handlers when interface is None (openwrt#403) 996659e feat: refactor service bus handler lookup to avoid linear searches (openwrt#400) 6531b93 fix: reduce size of wheels (openwrt#399) a4c2743 feat: reduce size of wheels (openwrt#398) e4f37ee feat: resync generic D-Bus errors (openwrt#393) 829e0fc feat: build macos arm wheels (openwrt#387) d7213be feat: speed up marshalling messages (openwrt#383) 89026e3 feat: speed up bytearray creation in unmarshaller (openwrt#382) c21a2ac fix: docs build (openwrt#381) 586dc23 fix: attempting to unmarshall some arrays twice (openwrt#380) 18132b9 fix: wheel builds on aarch64 (openwrt#367) bdf08d2 feat: migrate to using native arm runners for wheel builds (openwrt#366) 5b61869 feat(introspect): implement annotations (openwrt#359) f58f1a6 fix: void validate arguments/properties name (openwrt#358) d376bb1 feat: improve performance of unmarshalling variants (openwrt#354) e1aaf0a feat: improve performance of marshalling message headers (openwrt#356) ebdf07e fix: revert avoid building wheels if a release is not made (openwrt#357) b1e6551 feat: speed up marshalling messages (openwrt#352) b162494 feat: speed up constructing messages from the unmarshaller (openwrt#344) 4116261 fix: race in test_tcp_connection_with_forwarding (openwrt#350) 5825758 feat: speed up unmarshalling headers (openwrt#347) a249777 fix: disable wheel builds for old python versions (openwrt#346) 1c20dcc fix: ensure exceptions are logged when no reply is expected (openwrt#342) 9c73022 fix: exclude .c files from being shipped (openwrt#331) 0f04a79 fix: remove deprecated no_type_check_decorator (openwrt#316) 2dabf2d fix: ensure build uses cython3 (openwrt#311) 1b7d28c fix: add missing cython version pin to the build system (openwrt#310) 42f1d4a feat: use dbus-run-session to drop X11 dependency (openwrt#299) 45c0e74 feat: python 3.13 support (openwrt#291) c44eb2c fix: wheel build exclude for pp37 (openwrt#285) d0ac990 feat: build wheels for aarch64 to allow use in embedded systems (openwrt#283) be68a79 fix: clear exception flag on disconnect future if its also sent to handlers (openwrt#281) 7da5d44 fix: introspection bogus child paths (openwrt#280) Signed-off-by: Quintin Hill <stuff@quintin.me.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haproxy can be built without the huge libopenssl dependency to use it as
a simple http load balancer. This patch adds a haproxy-nossl variant to
the haproxy Makefile, which builds haproxy with the USE_OPENSSL flag
disabled.
Signed-off-by: Vikraman Choudhury vikraman@gentoo.org