Add support for tracking network interfaces on routers and identities. Fixes #3082. Add network discover to router. Fixes #3083 #3097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5719aad to
1b419ea
Compare
| if ctx.ProceedWithSet(FieldInterfaces) { | ||
| m := map[string]any{} | ||
| for idx, v := range interfaces { | ||
| m[fmt.Sprintf("%d.%s", idx, v.Name)] = v.toBoltMap() |
There was a problem hiding this comment.
So this uses the report order + interface name as the unique key? If the OS reports the order differently, it would have to be an entirely new map with every update.
It isn't an issue as long as we never directly reference the key values as foreign keys and only use this as information for a user to make other decisions. Otherwise, MAC address would probably have been better.
There was a problem hiding this comment.
The list is always sorted by name, so the order should be consistent. interface names are supposed to be unique, so the index shouldn't even be required, but I added it just in case there was some oddity. The value is never exposed to the end user.
andrewpmartinez
approved these changes
Jun 17, 2025
1b419ea to
cc7eefa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.