fix ha circuit id gen #3125
Merged
fix ha circuit id gen #3125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
- ids used by circuits and ingress/egress can conflict in an HA setup. Fixes ids used by circuits and ingress/egress can conflict in an HA setup #3124
- Update deps and changelog
| @@ -51,10 +51,20 @@ func (self *shortIdGenerator) NextId() (string, error) { | |||
| } | |||
| } | |||
|
|
|||
| func NewUUIDString() string { | |||
| func MustNewUUIDString() string { | |||
There was a problem hiding this comment.
"MustNew" ? Does the panic ever happen? It seems weird to panic at all rather than pass back an error.
There was a problem hiding this comment.
I would guess that the error never happens, but before we were ignoring the error. I figured it was better to find out that something had gone wrong than not.
There was a problem hiding this comment.
I'll make a note to go back and switch all the uses over to the error returning one.
There was a problem hiding this comment.
If that were the case, I suggest making the original method panic and using that everywhere.
andrewpmartinez
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.