Check pid file #1147
Merged
Check pid file #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faacdf7 to
9723638
Compare
…ight information Signed-off-by: Wang Long <long.wanglong@huawei.com>
9723638 to
2c74f86
Compare
|
LGTM. Thanks. 😸 |
mikebrow
reviewed
Oct 25, 2016
| @@ -51,7 +51,7 @@ function teardown() { | |||
|
|
|||
| run cat pid.txt | |||
| [ "$status" -eq 0 ] | |||
| [[ ${lines[0]} =~ [0-9]+ ]] | |||
There was a problem hiding this comment.
Why delete the digit test here.... but not below.
| @@ -42,6 +42,7 @@ function teardown() { | |||
| run cat pid.txt | |||
| [ "$status" -eq 0 ] | |||
| [[ ${lines[0]} =~ [0-9]+ ]] | |||
There was a problem hiding this comment.
Because this check is negative (is the pid not the main container pid) while the other checks are positive (is the pid the main container pid). So we need to retain the "is this actually a number" check.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At #1132 (review), It is necessary to make sure that pid-file contains the right information.
This patch employ
jqandrunc statecommand to achieve it.Signed-off-by: Wang Long long.wanglong@huawei.com