make: validate C format #1699
Merged
make: validate C format #1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
reviewed
Jan 23, 2018
libcontainer/nsenter/nsexec.c
Outdated
| static int clone_parent(jmp_buf *env, int jmpval) __attribute__ ((noinline)); | ||
| static int clone_parent(jmp_buf *env, int jmpval) | ||
| static int clone_parent(jmp_buf * env, int jmpval) __attribute__ ((noinline)); | ||
| static int clone_parent(jmp_buf * env, int jmpval) |
There was a problem hiding this comment.
This change doesn't appear to make sense -- jmp_buf *env is the Linux kernel style, no? I'll have to double check why indent is doing that...
There was a problem hiding this comment.
According to man:
You must use the ‘-T’ option to tell indent the name of all the typenames in your program that are defined by typedef.
Updated PR
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
|
Should we be running the check as part of CI? Maybe you can add it to LGTM otherwise. |
|
It is already added. (travis -> make ci -> make validate -> validate-c) |
|
Ah, my apologies. Still LGTM. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp
Options for
indentare taken from #950 (comment)@cyphar PTAL?