8000 Add zfs localpv dashboard by rajaSahil · Pull Request #74 · openebs/monitoring · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add zfs localpv dashboard #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2021

Conversation

rajaSahil
Copy link
Contributor
@rajaSahil rajaSahil commented Sep 16, 2021

What this PR does?

Screenshots:

Screenshot from 2021-09-16 14-15-32
Screenshot from 2021-09-16 16-19-10
Screenshot from 2021-09-16 16-19-18

// To generate prometheusRule yamls. If set, prometheusRule will be generated.
alertRules: false,
// ServiceMonitor configuration
serviceMonitor: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be true or false?

Copy link
Contributor Author
@rajaSahil rajaSahil Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no alert rules, serviceMonitor and podMonitor for zfs localpv. Therefore it is set as false.
The dashboard is built using node-exporter metrics.

@@ -0,0 +1,1245 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just recollecting.. why do we need to check-in the same file twice?

Copy link
Contributor Author
@rajaSahil rajaSahil Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To include the dashboard in helm installation, we are generating a dashboard using mixin.

@rajaSahil rajaSahil self-assigned this Sep 16, 2021
"style": "dark",
"tags": [
"OpenEBS",
"ZFS-LocalPV"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in lower case or upper case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. For lvm pool dashboard, we have used uppercase.

@Ab-hishek
Copy link
Contributor
Ab-hishek commented Sep 16, 2021

In the Used Space panel, I see repeating legends. Is this the expected visualization? IMO, I feel better to have legends in table format with the avg % shown.

@rajaSahil
Copy link
Contributor Author
rajaSahil commented Sep 16, 2021

I haven't made any changes to the dashboard panels or legends. Will update the legends in table format.

Signed-off-by: Sahil Raja <sahilraja242@gmail.com>

Generate dashbaord for helm

Signed-off-by: Sahil Raja <sahilraja242@gmail.com>

Chart version bumped

Signed-off-by: Sahil Raja <sahilraja242@gmail.com>
Signed-off-by: Sahil Raja <sahilraja242@gmail.com>
Signed-off-by: Sahil Raja <sahilraja242@gmail.com>
@rajaSahil rajaSahil force-pushed the Add-zfs-localpv-dashboard branch from 2d23f3b to d3333f1 Compare September 16, 2021 10:57
@rajaSahil
Copy link
Contributor Author

@Ab-hishek repeated legends were being shown because of my setup. Have updated the dashboard screenshots.

Signed-off-by: Sahil Raja <sahilraja242@gmail.com>
Copy link
Member
@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kmova kmova merged commit 2c79050 into openebs:develop Sep 17, 2021
@kmova kmova mentioned this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
471B
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0