-
Notifications
You must be signed in to change notification settings - Fork 22
Add zfs localpv dashboard #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
// To generate prometheusRule yamls. If set, prometheusRule will be generated. | ||
alertRules: false, | ||
// ServiceMonitor configuration | ||
serviceMonitor: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be true or false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no alert rules, serviceMonitor and podMonitor for zfs localpv. Therefore it is set as false.
The dashboard is built using node-exporter metrics.
@@ -0,0 +1,1245 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just recollecting.. why do we need to check-in the same file twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To include the dashboard in helm installation, we are generating a dashboard using mixin.
"style": "dark", | ||
"tags": [ | ||
"OpenEBS", | ||
"ZFS-LocalPV" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in lower case or upper case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. For lvm
pool dashboard, we have used uppercase.
In the |
I haven't made any changes to the dashboard panels or legends. Will update the legends in table format. |
Signed-off-by: Sahil Raja <sahilraja242@gmail.com> Generate dashbaord for helm Signed-off-by: Sahil Raja <sahilraja242@gmail.com> Chart version bumped Signed-off-by: Sahil Raja <sahilraja242@gmail.com>
Signed-off-by: Sahil Raja <sahilraja242@gmail.com>
Signed-off-by: Sahil Raja <sahilraja242@gmail.com>
2d23f3b
to
d3333f1
Compare
@Ab-hishek repeated legends were being shown because of my setup. Have updated the dashboard screenshots. |
Signed-off-by: Sahil Raja <sahilraja242@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
What this PR does?
Screenshots: