typo #91
typo #91
Conversation
| @@ -3960,7 +3960,7 @@ | |||
| "schemaVersion": 27, | |||
| "style": "dark", | |||
| "tags": [ | |||
| "openEBS", | |||
| "OpenEBS", | |||
There was a problem hiding this comment.
We need to keep the dashboards in sync-up both for helm and mixins. So, what you can do is make this change inside the openebs-mixin dashboards and then run make generate command which will automatically generate the dashboards for helm charts.
There was a problem hiding this comment.
I don't see the typo in mixin, so it was probably already fixed there, but the person forgot to run the make command.
There was a problem hiding this comment.
@Ab-hishek I'm on a Windows system, I try to install jsonnet with pip on Ubuntu in a VM but I got compilation errors. Look like I don't have a environment that is ready to compile those dashboard using jb.
There was a problem hiding this comment.
it was fixed here : https://github.com/openebs/monitoring/pull/76/files but the dashboard weren't regenerated.
There was a problem hiding this comment.
Cool! We also need to update the chart version since we are making a change inside dashboard contents.
There was a problem hiding this comment.
I did previously a chart update, but I forgot that one. Should we do a chart update on each PR or it's done at the end of a sprint if there are changes ?
There was a problem hiding this comment.
We need to do a chart update everything some changes are introduced in the helm charts be it a README update or templates update or values.yaml file changes...
There was a problem hiding this comment.
Although that's a good point. We will try to only update the chart version at the end of sprints.
No description provided.