8000 [BUG] Wrong permission check walking HGATP · Issue #2910 · openhwgroup/cva6 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUG] Wrong permission check walking HGATP #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NicolasDerumigny opened this issue Apr 9, 2025 · 1 comment · May be fixed by #2978
Closed

[BUG] Wrong permission check walking HGATP #2910

NicolasDerumigny opened this issue Apr 9, 2025 · 1 comment · May be fixed by #2978
Labels
notCV32A65X It is not an CV32A65X issue Status:Stale Issue or PR is stale and hasn't received any updates.

Comments

@NicolasDerumigny
Copy link

When a store instruction in executed on VM mode (V=1), HGATP walks for non-leaf nodes should only be checked for readability (P, R, A bits).

I think this line lacks && (ptw_stage_q != G_INTERMED_STAGE) to do so, but I am not an expert in SystemVerilog.

cva6/core/cva6_mmu/cva6_ptw.sv

Line 475 in b9da1d9

if (lsu_is_store_i && (!pte.w || !pte.d)) begin

I am a system developer porting virtualization modules on the CVA6, and notice virtual guest store page fault with translation error during walk when the VSATP nodes are read-only in HGATP, hence my supposition.
@JeanRochCoulon JeanRochCoulon added the notCV32A65X It is not an CV32A65X issue label Apr 10, 2025
@NicolasDerumigny NicolasDerumigny mentioned this issue Apr 15, 2025
Open
@NicolasDerumigny NicolasDerumigny changed the title Wrong permission check walking HGATP [BUG] Wrong permission check walking HGATP Apr 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi there!

This issue seems inactive. Need more help? Feel free to update us. If there are no updates within the next few days, we'll go ahead and close this issue. 😊

@github-actions github-actions bot added the Status:Stale Issue or PR is stale and hasn't received any updates. label May 24, 2025
@NicolasDerumigny NicolasDerumigny mentioned this issue May 26, 2025
Open
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
notCV32A65X It is not an CV32A65X issue Status:Stale Issue or PR is stale and hasn't received any updates.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PTW: Coding style + H-Mode fixes NicolasDerumigny/cva6
2 participants
@NicolasDerumigny @JeanRochCoulon
0