8000 PTW: Coding style + H-Mode fixes by NicolasDerumigny · Pull Request #2978 · openhwgroup/cva6 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PTW: Coding style + H-Mode fixes #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

PTW: Coding style + H-Mode fixes #2978

wants to merge 6 commits into from

Conversation

NicolasDerumigny
Copy link

Break-down of #2933 : PTW changes only:

  • walks on intermediate nodes during G-translation do no generate faults if R/D/X bits is not set and request is a store (fixes [BUG] Wrong permission check walking HGATP #2910)
  • walks on intermediate nodes during G-translation do no generate faults if X bits is not set and request is an execute

Code style:

  • gather requests to the TLB in a single process instead of scattered signals
  • add more comments

@NicolasDerumigny NicolasDerumigny force-pushed the dev/nderumigny/ptw-coding-style branch from 218ff12 to f88b49c Compare May 26, 2025 14:56
@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

@NicolasDerumigny NicolasDerumigny mentioned this pull request May 26, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

YazanHussnain-10x
YazanHussnain-10x suggested changes May 29, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YazanHussnain-10x YazanHussnain-10x YazanHussnain-10x requested changes

@JeanRochCoulon JeanRochCoulon Awaiting requested review from JeanRochCoulon JeanRochCoulon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong permission check walking HGATP
2 participants
@NicolasDerumigny @YazanHussnain-10x
0