8000 Fix: blue-green batch-id e2e fails sometime by AiRanthem · Pull Request #261 · openkruise/rollouts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: blue-green batch-id e2e fails sometime #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

AiRanthem
Copy link
Member
@AiRanthem AiRanthem commented Mar 24, 2025

Ⅰ. Describe what this PR does

The patchPodLabels operation is moved from UpgradeBatch to CheckBatchReady. The reason for doing this is that UpgradeBatch only modifies the replica information of the workload, and performing patchPodLabels here may not be able to promptly read the pods that have not been created; whereas CheckBatchReady will continuously check until all the expected Pods are ready, therefore the patch should be performed before the check.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Special notes for reviews

Copy link
codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.24%. Comparing base (056c77d) to head (d058733).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   45.55%   45.24%   -0.32%     
==========================================
  Files          57       61       +4     
  Lines        6395     7060     +665     
==========================================
+ Hits         2913     3194     +281     
- Misses       2989     3317     +328     
- Partials      493      549      +56     
Flag Coverage Δ
unittests 45.24% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kruise-bot kruise-bot added size/S and removed size/XS labels Mar 24, 2025
@AiRanthem AiRanthem force-pushed the fix/batch-id-e2e-250324 branch from d058733 to ed18683 Compare March 24, 2025 11:19
@kruise-bot kruise-bot added size/M and removed size/S labels Mar 24, 2025
@AiRanthem AiRanthem force-pushed the fix/batch-id-e2e-250324 branch 2 times, most recently from 0fe2ebb to 7142291 Compare March 25, 2025 07:50
@kruise-bot kruise-bot added size/L and removed size/M labels Mar 25, 2025
@AiRanthem AiRanthem marked this pull request as ready for review March 25, 2025 09:31
@kruise-bot kruise-bot requested a review from FillZpp March 25, 2025 09:31
@AiRanthem AiRanthem force-pushed the fix/batch-id-e2e-250324 branch from 349188e to dcab61c Compare March 25, 2025 09:32
@@ -126,7 +126,9 @@ func (rc *realBatchControlPlane) CheckBatchReady() error {

klog.Infof("BatchRelease %v calculated context when check batch ready: %s",
klog.KObj(rc.release), batchContext.Log())

if err = rc.patchPodLabels(batchContext); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can add a TODO to patch labels only if number of labeled pods is not equal to the one of total pods

Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
@AiRanthem AiRanthem force-pushed the fix/batch-id-e2e-250324 branch from de4485d to ec34bb5 Compare April 1, 2025 03:09
Copy link
Member
@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@furykerry furykerry merged commit 7444303 into openkruise:master Apr 1, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0