-
Notifications
You must be signed in to change notification settings - Fork 77
Fix: blue-green batch-id e2e fails sometime #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: blue-green batch-id e2e fails sometime #261
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 45.55% 45.24% -0.32%
==========================================
Files 57 61 +4
Lines 6395 7060 +665
==========================================
+ Hits 2913 3194 +281
- Misses 2989 3317 +328
- Partials 493 549 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d058733
to
ed18683
Compare
0fe2ebb
to
7142291
Compare
349188e
to
dcab61c
Compare
@@ -126,7 +126,9 @@ func (rc *realBatchControlPlane) CheckBatchReady() error { | |||
|
|||
klog.Infof("BatchRelease %v calculated context when check batch ready: %s", | |||
klog.KObj(rc.release), batchContext.Log()) | |||
|
|||
if err = rc.patchPodLabels(batchContext); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can add a TODO to patch labels only if number of labeled pods is not equal to the one of total pods
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
de4485d
to
ec34bb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
The patchPodLabels operation is moved from UpgradeBatch to CheckBatchReady. The reason for doing this is that UpgradeBatch only modifies the replica information of the workload, and performing patchPodLabels here may not be able to promptly read the pods that have not been created; whereas CheckBatchReady will continuously check until all the expected Pods are ready, therefore the patch should be performed before the check.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Special notes for reviews