dnsmasq: Fix wildcard host handling #8734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still have to check one more thing so draft until later. |
…with no domain specified.
|
Okay done. |
AdSchellevis
requested changes
May 29, 2025
There was a problem hiding this comment.
@Monviech some remarks, but in general I have no objections (we just need to add HostWildcardAllowed to the hostname field)
| @@ -54,6 +58,26 @@ domain={{dnsmasq.dhcp.domain|default(system.domain)}} | |||
| local=/{{ domain }}/ | |||
| {% endfor %} | |||
| {% endif %} | |||
| {% if all_wildcard_hosts %} | |||
There was a problem hiding this comment.
we can probably ditch the if here as an empty list won't yield output anyway.
There was a problem hiding this comment.
I wanted to show the comment block conditionally in the rendered config.
Co-authored-by: Ad Schellevis <AdSchellevis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8731